diff options
| author | rafaelw@chromium.org <rafaelw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-05-20 05:01:03 +0000 |
|---|---|---|
| committer | rafaelw@chromium.org <rafaelw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-05-20 05:01:03 +0000 |
| commit | ff6456c561bc99141ff06384c8c3fbd45162a628 (patch) | |
| tree | 0a133d7d992ba374d48fd182495fbebc1407d33f /chrome/browser/extensions/extension_tabs_module.h | |
| parent | 123603228f84d9d63f6e247b73574cbc0bb68819 (diff) | |
| download | chromium_src-ff6456c561bc99141ff06384c8c3fbd45162a628.zip chromium_src-ff6456c561bc99141ff06384c8c3fbd45162a628.tar.gz chromium_src-ff6456c561bc99141ff06384c8c3fbd45162a628.tar.bz2 | |
tabs.onUpdated now sends 'url' when 'state' has changed to 'loading' when navigating to a new url. If a reload is in progress, 'loading' will not be accompanied by 'url'.
Also, refactored some code so that string constants are defined and shared.
BUG=11200
R=erikkay
Review URL: http://codereview.chromium.org/113552
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16467 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/extensions/extension_tabs_module.h')
| -rw-r--r-- | chrome/browser/extensions/extension_tabs_module.h | 31 |
1 files changed, 30 insertions, 1 deletions
diff --git a/chrome/browser/extensions/extension_tabs_module.h b/chrome/browser/extensions/extension_tabs_module.h index 2dd2c27..7e27e37 100644 --- a/chrome/browser/extensions/extension_tabs_module.h +++ b/chrome/browser/extensions/extension_tabs_module.h @@ -23,6 +23,36 @@ class ExtensionTabUtil { TAB_COMPLETE // Tab loading and rendering is complete. }; + // Keys used in serializing tab data & events. + static const wchar_t* kDataKey; + static const wchar_t* kFavIconUrlKey; + static const wchar_t* kFocusedKey; + static const wchar_t* kFromIndexKey; + static const wchar_t* kHeightKey; + static const wchar_t* kIdKey; + static const wchar_t* kIndexKey; + static const wchar_t* kLeftKey; + static const wchar_t* kNewPositionKey; + static const wchar_t* kNewWindowIdKey; + static const wchar_t* kOldPositionKey; + static const wchar_t* kOldWindowIdKey; + static const wchar_t* kPageActionIdKey; + static const wchar_t* kSelectedKey; + static const wchar_t* kStatusKey; + static const wchar_t* kTabIdKey; + static const wchar_t* kTabsKey; + static const wchar_t* kTabUrlKey; + static const wchar_t* kTitleKey; + static const wchar_t* kToIndexKey; + static const wchar_t* kTopKey; + static const wchar_t* kUrlKey; + static const wchar_t* kWidthKey; + static const wchar_t* kWindowIdKey; + + // Value consts. + static const char* kStatusValueComplete; + static const char* kStatusValueLoading; + static int GetWindowId(const Browser* browser); static int GetTabId(const TabContents* tab_contents); static TabStatus GetTabStatus(const TabContents* tab_contents); @@ -32,7 +62,6 @@ class ExtensionTabUtil { static DictionaryValue* CreateTabValue(const TabContents* tab_contents, TabStripModel* tab_strip, int tab_index); - static DictionaryValue* CreateTabChangedValue(const TabContents* contents); // Any out parameter (|browser|, |tab_strip|, |contents|, & |tab_index|) may // be NULL and will not be set within the function. |