diff options
author | finnur@chromium.org <finnur@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-06-02 20:36:35 +0000 |
---|---|---|
committer | finnur@chromium.org <finnur@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-06-02 20:36:35 +0000 |
commit | b0bcc0b4b2e25b0368eb8b98d760ac68d9d14ef3 (patch) | |
tree | 8a3be0fd39d21621779799c45242ef894ef02adc /chrome/browser/extensions/extension_toolbar_model_browsertest.cc | |
parent | 3b0e466e530c99fe730a9a5e11dd416c48e052f8 (diff) | |
download | chromium_src-b0bcc0b4b2e25b0368eb8b98d760ac68d9d14ef3.zip chromium_src-b0bcc0b4b2e25b0368eb8b98d760ac68d9d14ef3.tar.gz chromium_src-b0bcc0b4b2e25b0368eb8b98d760ac68d9d14ef3.tar.bz2 |
Add traces temporarily to track down flakiness in test.
BUG=379170
TBR=asargent
Review URL: https://codereview.chromium.org/309533013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274316 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/extensions/extension_toolbar_model_browsertest.cc')
-rw-r--r-- | chrome/browser/extensions/extension_toolbar_model_browsertest.cc | 17 |
1 files changed, 10 insertions, 7 deletions
diff --git a/chrome/browser/extensions/extension_toolbar_model_browsertest.cc b/chrome/browser/extensions/extension_toolbar_model_browsertest.cc index ed3c0f6..6bce3aa 100644 --- a/chrome/browser/extensions/extension_toolbar_model_browsertest.cc +++ b/chrome/browser/extensions/extension_toolbar_model_browsertest.cc @@ -584,30 +584,33 @@ IN_PROC_BROWSER_TEST_F(ExtensionToolbarModelTest, HighlightModeAdd) { EXPECT_EQ(id_c, ExtensionAt(2)->id()); } -// Test is flaky on Linus and ChromeOS, see crbug.com/379170. -#if defined(OS_LINUX) || defined(OS_CHROMEOS) -#define MAYBE_SizeAfterPrefChange DISABLED_SizeAfterPrefChange -#else -#define MAYBE_SizeAfterPrefChange SizeAfterPrefChange -#endif -IN_PROC_BROWSER_TEST_F(ExtensionToolbarModelTest, MAYBE_SizeAfterPrefChange) { +// Test is flaky (see crbug.com/379170), but currently enabled to gather traces. +// If it fails, ping Finnur. +IN_PROC_BROWSER_TEST_F(ExtensionToolbarModelTest, SizeAfterPrefChange) { // Load two extensions with browser action. base::FilePath extension_a_path(test_data_dir_.AppendASCII("api_test") .AppendASCII("browser_action") .AppendASCII("basics")); + LOG(ERROR) << "Loading [basics]"; ASSERT_TRUE(LoadExtension(extension_a_path)); base::FilePath extension_b_path(test_data_dir_.AppendASCII("api_test") .AppendASCII("browser_action") .AppendASCII("popup")); + LOG(ERROR) << "Loading [popup]"; ASSERT_TRUE(LoadExtension(extension_b_path)); std::string id_a = ExtensionAt(0)->id(); std::string id_b = ExtensionAt(1)->id(); + LOG(ERROR) << "GetVisibleIconCount"; + // Should be at max size (-1). EXPECT_EQ(-1, model_->GetVisibleIconCount()); + LOG(ERROR) << "OnExtensionToolbarPrefChange"; model_->OnExtensionToolbarPrefChange(); + LOG(ERROR) << "GetVisibleIconCount"; + // Should still be at max size. EXPECT_EQ(-1, model_->GetVisibleIconCount()); } |