diff options
| author | jhawkins@chromium.org <jhawkins@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-07-31 19:51:46 +0000 |
|---|---|---|
| committer | jhawkins@chromium.org <jhawkins@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-07-31 19:51:46 +0000 |
| commit | 2104671bcd53e386ab63e5856ba058503c4a75e2 (patch) | |
| tree | 2f9c345f9a4c39203d034487c63f6a5195400488 /chrome/browser/extensions/extension_uitest.cc | |
| parent | 0298d9c293255381f87e6fe1a6bb2927c4feffb5 (diff) | |
| download | chromium_src-2104671bcd53e386ab63e5856ba058503c4a75e2.zip chromium_src-2104671bcd53e386ab63e5856ba058503c4a75e2.tar.gz chromium_src-2104671bcd53e386ab63e5856ba058503c4a75e2.tar.bz2 | |
Coverity: Check the return value of DictionaryValue::GetString.
CID=4199,4685
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/159677
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22173 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/extensions/extension_uitest.cc')
| -rw-r--r-- | chrome/browser/extensions/extension_uitest.cc | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/chrome/browser/extensions/extension_uitest.cc b/chrome/browser/extensions/extension_uitest.cc index 89faa41..fed09d8 100644 --- a/chrome/browser/extensions/extension_uitest.cc +++ b/chrome/browser/extensions/extension_uitest.cc @@ -129,11 +129,11 @@ TEST_F(SimpleApiCallExtensionTest, RunTest) { DictionaryValue* message_dict = reinterpret_cast<DictionaryValue*>(message_value.get()); std::string result; - message_dict->GetString(keys::kAutomationNameKey, &result); + ASSERT_TRUE(message_dict->GetString(keys::kAutomationNameKey, &result)); EXPECT_EQ(result, "tabs.remove"); result = ""; - message_dict->GetString(keys::kAutomationArgsKey, &result); + ASSERT_TRUE(message_dict->GetString(keys::kAutomationArgsKey, &result)); EXPECT_NE(result, ""); int callback_id = 0xBAADF00D; @@ -347,7 +347,7 @@ void BrowserEventAutomationProxy::HandleMessageFromChrome() { std::string origin(origin()); std::string target(target()); - ASSERT_TRUE(message.length() > 0); + ASSERT_GT(message.length(), 0); ASSERT_STREQ(keys::kAutomationOrigin, origin.c_str()); if (target == keys::kAutomationRequestTarget) { @@ -360,7 +360,7 @@ void BrowserEventAutomationProxy::HandleMessageFromChrome() { reinterpret_cast<DictionaryValue*>(message_value.get()); std::string name; - message_dict->GetString(keys::kAutomationNameKey, &name); + ASSERT_TRUE(message_dict->GetString(keys::kAutomationNameKey, &name)); ASSERT_STREQ(name.c_str(), "windows.getCurrent"); // Send an OpenChannelToExtension message to chrome. Note: the JSON @@ -392,7 +392,7 @@ void BrowserEventAutomationProxy::HandleMessageFromChrome() { reinterpret_cast<DictionaryValue*>(message_value.get()); std::string event_name; - message_dict->GetString(L"data", &event_name); + ASSERT_TRUE(message_dict->GetString(L"data", &event_name)); if (event_name == "\"ACK\"") { ASSERT_EQ(0, event_count_.size()); } else { |