diff options
| author | erikkay@google.com <erikkay@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-01-12 19:36:42 +0000 |
|---|---|---|
| committer | erikkay@google.com <erikkay@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-01-12 19:36:42 +0000 |
| commit | 64a02b8056c86576428022859baadbb9a7b929f1 (patch) | |
| tree | fba294d94f03345806aeb15f6a2fbb2d8fd652f6 /chrome/browser/extensions/extension_unittest.cc | |
| parent | af05c6aa88661f7595b6a883667c352d51e66eb7 (diff) | |
| download | chromium_src-64a02b8056c86576428022859baadbb9a7b929f1.zip chromium_src-64a02b8056c86576428022859baadbb9a7b929f1.tar.gz chromium_src-64a02b8056c86576428022859baadbb9a7b929f1.tar.bz2 | |
Add version to list of required fields. This is required prep work for extension installation.
Review URL: http://codereview.chromium.org/17320
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7887 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/extensions/extension_unittest.cc')
| -rw-r--r-- | chrome/browser/extensions/extension_unittest.cc | 9 |
1 files changed, 9 insertions, 0 deletions
diff --git a/chrome/browser/extensions/extension_unittest.cc b/chrome/browser/extensions/extension_unittest.cc index 7aa51a0..71812b9 100644 --- a/chrome/browser/extensions/extension_unittest.cc +++ b/chrome/browser/extensions/extension_unittest.cc @@ -28,6 +28,14 @@ TEST(ExtensionTest, InitFromValueInvalid) { EXPECT_EQ(Extension::kInvalidIdError, error); input_value.SetString(Extension::kIdKey, L"com.google.myextension"); + // Test missing and invalid versions + EXPECT_FALSE(extension.InitFromValue(input_value, &error)); + EXPECT_EQ(Extension::kInvalidVersionError, error); + input_value.SetInteger(Extension::kVersionKey, 42); + EXPECT_FALSE(extension.InitFromValue(input_value, &error)); + EXPECT_EQ(Extension::kInvalidVersionError, error); + input_value.SetString(Extension::kVersionKey, L"1.0"); + // Test missing and invalid names EXPECT_FALSE(extension.InitFromValue(input_value, &error)); EXPECT_EQ(Extension::kInvalidNameError, error); @@ -64,6 +72,7 @@ TEST(ExtensionTest, InitFromValueValid) { // Test minimal extension input_value.SetInteger(Extension::kFormatVersionKey, 1); input_value.SetString(Extension::kIdKey, L"com.google.myextension"); + input_value.SetString(Extension::kVersionKey, L"1.0"); input_value.SetString(Extension::kNameKey, L"my extension"); EXPECT_TRUE(extension.InitFromValue(input_value, &error)); |