diff options
| author | nsylvain@chromium.org <nsylvain@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-11-30 05:07:55 +0000 |
|---|---|---|
| committer | nsylvain@chromium.org <nsylvain@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-11-30 05:07:55 +0000 |
| commit | 2c58efc6135102d815c34d518d14c0bfc5c27f5b (patch) | |
| tree | bf47fee779ada375a0007e4cc7b527e86a0293a3 /chrome/browser/extensions/extensions_service.cc | |
| parent | 48844c643cca3d7d21043e46c228585e68618e31 (diff) | |
| download | chromium_src-2c58efc6135102d815c34d518d14c0bfc5c27f5b.zip chromium_src-2c58efc6135102d815c34d518d14c0bfc5c27f5b.tar.gz chromium_src-2c58efc6135102d815c34d518d14c0bfc5c27f5b.tar.bz2 | |
Revert 33255 - Report active extensions in crash reports. This only implements Windows right now. Mac and linux will be separate CLs.
"Active" is overloaded to mean different things depending on
the process type:
browser: all enabled extensions
renderer: unique set of extensions from all user scripts
extension: extensions running in the process
BUG=27169
Review URL: http://codereview.chromium.org/437078
--
There are thousands of new crashes with reivison 33256 and 33255, so i'm
reverting. the crashes are in chrome_2610000!child_process_logging::SetActiveURL
TBR=aa@chromium.org
Review URL: http://codereview.chromium.org/448006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33269 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/extensions/extensions_service.cc')
| -rw-r--r-- | chrome/browser/extensions/extensions_service.cc | 13 |
1 files changed, 0 insertions, 13 deletions
diff --git a/chrome/browser/extensions/extensions_service.cc b/chrome/browser/extensions/extensions_service.cc index 2a40a37..b185150 100644 --- a/chrome/browser/extensions/extensions_service.cc +++ b/chrome/browser/extensions/extensions_service.cc @@ -25,7 +25,6 @@ #include "chrome/browser/extensions/external_pref_extension_provider.h" #include "chrome/browser/profile.h" #include "chrome/browser/net/chrome_url_request_context.h" -#include "chrome/common/child_process_logging.h" #include "chrome/common/chrome_switches.h" #include "chrome/common/extensions/extension.h" #include "chrome/common/extensions/extension_constants.h" @@ -411,8 +410,6 @@ void ExtensionsService::NotifyExtensionLoaded(Extension* extension) { void ExtensionsService::NotifyExtensionUnloaded(Extension* extension) { LOG(INFO) << "Sending EXTENSION_UNLOADED"; - UpdateActiveExtensionsInCrashReporter(); - NotificationService::current()->Notify( NotificationType::EXTENSION_UNLOADED, Source<Profile>(profile_), @@ -624,16 +621,6 @@ void ExtensionsService::OnExtensionLoaded(Extension* extension, break; } } - - UpdateActiveExtensionsInCrashReporter(); -} - -void ExtensionsService::UpdateActiveExtensionsInCrashReporter() { - std::vector<std::string> extension_ids; - for (size_t i = 0; i < extensions_.size(); ++i) - extension_ids.push_back(extensions_[i]->id()); - - child_process_logging::SetActiveExtensions(extension_ids); } void ExtensionsService::OnExtensionInstalled(Extension* extension, |