summaryrefslogtreecommitdiffstats
path: root/chrome/browser/extensions/extensions_startup.cc
diff options
context:
space:
mode:
authormiket@chromium.org <miket@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2011-10-10 21:09:14 +0000
committermiket@chromium.org <miket@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2011-10-10 21:09:14 +0000
commite5af875fe7c4ab28ab985855531656eccdb08b58 (patch)
tree3bed04c3c9a1d0921770cb80e8b66a71853dda4f /chrome/browser/extensions/extensions_startup.cc
parent15edee45516a54fd066c2ca60b0f9ca4f5baae28 (diff)
downloadchromium_src-e5af875fe7c4ab28ab985855531656eccdb08b58.zip
chromium_src-e5af875fe7c4ab28ab985855531656eccdb08b58.tar.gz
chromium_src-e5af875fe7c4ab28ab985855531656eccdb08b58.tar.bz2
Notify users about certain changes in installed extensions.
This is an interim checkin. The added code is unreachable. Remaining: - Implement concept of orphaned extensions. Currently hardcoded false. - Once GlobalError's view supports DOMView, enhance to allow selective disabling of extensions. - Add unit test for ExtensionGlobalError (though there isn't much to test). - Get real UI layout and text. Currently placeholder text. - Bug: extensions page opens in new window, not new tab. - Bug: once we've determined that an alert needs to be displayed, the alert doesn't actually display until the next window open. We ought to add a different trigger. This might be a systemwide decision, so I'd like sail's input. BUG=94494 TEST=enhanced ExtensionPref unit tests. Review URL: http://codereview.chromium.org/8202011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104782 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/extensions/extensions_startup.cc')
-rw-r--r--chrome/browser/extensions/extensions_startup.cc8
1 files changed, 2 insertions, 6 deletions
diff --git a/chrome/browser/extensions/extensions_startup.cc b/chrome/browser/extensions/extensions_startup.cc
index 812b4dc..5d505ac 100644
--- a/chrome/browser/extensions/extensions_startup.cc
+++ b/chrome/browser/extensions/extensions_startup.cc
@@ -79,12 +79,8 @@ bool ExtensionsStartupUtil::UninstallExtension(const CommandLine& cmd_line,
std::string extension_id = cmd_line.GetSwitchValueASCII(
switches::kUninstallExtension);
- if (ExtensionService::UninstallExtensionHelper(extension_service,
- extension_id)) {
- return true;
- }
-
- return false;
+ return ExtensionService::UninstallExtensionHelper(extension_service,
+ extension_id);
}
ExtensionsStartupUtil::~ExtensionsStartupUtil() {