diff options
| author | rafaelw@chromium.org <rafaelw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-03-24 20:52:22 +0000 |
|---|---|---|
| committer | rafaelw@chromium.org <rafaelw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-03-24 20:52:22 +0000 |
| commit | 40362258cc6355f117648ad34ea9374f787609ff (patch) | |
| tree | da851e5cad8ff3776ac1f766ece29d00adff6fda /chrome/browser/extensions/extensions_ui.cc | |
| parent | 34f73fbb389c0e4555b2ab0f03748f95ea1c02fe (diff) | |
| download | chromium_src-40362258cc6355f117648ad34ea9374f787609ff.zip chromium_src-40362258cc6355f117648ad34ea9374f787609ff.tar.gz chromium_src-40362258cc6355f117648ad34ea9374f787609ff.tar.bz2 | |
Add instructions to chrome://extensions page for inspecting popups.
Under "Inspect Active Views", any extension that has a browser or page action will show grayed text directing the developer to right click on the icon and select 'Inspect Popup'
BUG=24477
TEST=Install an extension with a page or browser action. Go to chrome://extensions, turn on developer mode. Verify that under "inspect active views", the new instructions appear.
Review URL: http://codereview.chromium.org/1198002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42529 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/extensions/extensions_ui.cc')
| -rw-r--r-- | chrome/browser/extensions/extensions_ui.cc | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/chrome/browser/extensions/extensions_ui.cc b/chrome/browser/extensions/extensions_ui.cc index 9c2fc3b..fc2850c 100644 --- a/chrome/browser/extensions/extensions_ui.cc +++ b/chrome/browser/extensions/extensions_ui.cc @@ -117,6 +117,8 @@ void ExtensionsUIHTMLSource::StartDataRequest(const std::string& path, l10n_util::GetString(IDS_EXTENSIONS_VERSION)); localized_strings.SetString(L"inspectViews", l10n_util::GetString(IDS_EXTENSIONS_INSPECT_VIEWS)); + localized_strings.SetString(L"inspectPopupsInstructions", + l10n_util::GetString(IDS_EXTENSIONS_INSPECT_POPUPS_INSTRUCTIONS)); localized_strings.SetString(L"disable", l10n_util::GetString(IDS_EXTENSIONS_DISABLE)); localized_strings.SetString(L"enable", @@ -788,6 +790,8 @@ DictionaryValue* ExtensionsDOMHandler::CreateExtensionDetailValue( views->Append(view_value); } extension_data->Set(L"views", views); + extension_data->SetBoolean(L"hasPopupAction", + extension->browser_action() || extension->page_action()); return extension_data; } |