diff options
| author | erg@google.com <erg@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-08-11 21:41:57 +0000 |
|---|---|---|
| committer | erg@google.com <erg@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-08-11 21:41:57 +0000 |
| commit | 0349ab5dc3d6aa0abd87e7c72c0cf3daeff975b1 (patch) | |
| tree | c61284e61c899ddc09815674216c92f6d72986d1 /chrome/browser/extensions/extensions_ui.h | |
| parent | 679bf0a53d0c01afd193d2da18a733d04b1cd9a8 (diff) | |
| download | chromium_src-0349ab5dc3d6aa0abd87e7c72c0cf3daeff975b1.zip chromium_src-0349ab5dc3d6aa0abd87e7c72c0cf3daeff975b1.tar.gz chromium_src-0349ab5dc3d6aa0abd87e7c72c0cf3daeff975b1.tar.bz2 | |
Extension package creation cleanup
Unify extension package creation code between command line and GUI methods.
Properly handle extension names with periods or trailing slashes.
Don't DCHECK when creating packages from the command line.
BUG=14720, 19103, 51110
TEST=run 'chrome --pack-extension=has.a.dot/' on an extension with period in its name; make sure it is packed correctly and a message indicating success is printed.
Review URL: http://codereview.chromium.org/3077022
Patch from Ilya Sherman <isherman@google.com>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55792 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/extensions/extensions_ui.h')
| -rw-r--r-- | chrome/browser/extensions/extensions_ui.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/chrome/browser/extensions/extensions_ui.h b/chrome/browser/extensions/extensions_ui.h index 2bf79e6..391cdc0 100644 --- a/chrome/browser/extensions/extensions_ui.h +++ b/chrome/browser/extensions/extensions_ui.h @@ -124,7 +124,7 @@ class ExtensionsDOMHandler virtual void OnPackSuccess(const FilePath& crx_file, const FilePath& key_file); - virtual void OnPackFailure(const std::string& message); + virtual void OnPackFailure(const std::string& error); // ExtensionInstallUI::Delegate implementation, used for receiving // notification about uninstall confirmation dialog selections. |