summaryrefslogtreecommitdiffstats
path: root/chrome/browser/extensions/external_pref_extension_provider.cc
diff options
context:
space:
mode:
authorjhawkins@chromium.org <jhawkins@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2009-07-24 17:38:59 +0000
committerjhawkins@chromium.org <jhawkins@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2009-07-24 17:38:59 +0000
commitf5ad75410da18f0963d1a4901e45fd71d051595a (patch)
tree5485c6a5dca701f4ebe1bac5572909900fc86523 /chrome/browser/extensions/external_pref_extension_provider.cc
parent03f152a414281c4c1d1382c8af7f4f2e6ea979d2 (diff)
downloadchromium_src-f5ad75410da18f0963d1a4901e45fd71d051595a.zip
chromium_src-f5ad75410da18f0963d1a4901e45fd71d051595a.tar.gz
chromium_src-f5ad75410da18f0963d1a4901e45fd71d051595a.tar.bz2
Coverity: Pass strings by reference.
CID=4459,4563,4564,4566,4567,4569,4570,4571,4803 BUG=none TEST=none Review URL: http://codereview.chromium.org/159342 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21540 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/extensions/external_pref_extension_provider.cc')
-rw-r--r--chrome/browser/extensions/external_pref_extension_provider.cc4
1 files changed, 2 insertions, 2 deletions
diff --git a/chrome/browser/extensions/external_pref_extension_provider.cc b/chrome/browser/extensions/external_pref_extension_provider.cc
index cc4b031..f2ea35a 100644
--- a/chrome/browser/extensions/external_pref_extension_provider.cc
+++ b/chrome/browser/extensions/external_pref_extension_provider.cc
@@ -31,7 +31,7 @@ ExternalPrefExtensionProvider::~ExternalPrefExtensionProvider() {
}
void ExternalPrefExtensionProvider::SetPreferencesForTesting(
- std::string json_data_for_testing) {
+ const std::string& json_data_for_testing) {
JSONStringValueSerializer serializer(json_data_for_testing);
SetPreferences(&serializer);
}
@@ -81,7 +81,7 @@ void ExternalPrefExtensionProvider::VisitRegisteredExtension(
}
Version* ExternalPrefExtensionProvider::RegisteredVersion(
- std::string id, Extension::Location* location) const {
+ const std::string& id, Extension::Location* location) const {
DictionaryValue* extension = NULL;
if (!prefs_->GetDictionary(ASCIIToWide(id), &extension))
return NULL;