diff options
author | jamesr@chromium.org <jamesr@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-07-18 09:28:55 +0000 |
---|---|---|
committer | jamesr@chromium.org <jamesr@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-07-18 09:28:55 +0000 |
commit | be9915fbccfaab301759501d888579976427acfb (patch) | |
tree | c7072e00db4305cb6b65a33895dbd1dbb47e709a /chrome/browser/extensions/navigation_observer.cc | |
parent | acdaa9963d419b7b72bd8201857a23f29f626959 (diff) | |
download | chromium_src-be9915fbccfaab301759501d888579976427acfb.zip chromium_src-be9915fbccfaab301759501d888579976427acfb.tar.gz chromium_src-be9915fbccfaab301759501d888579976427acfb.tar.bz2 |
Remove ExtensionURLInfo, make security decisions in render process
When asking if an extension should have access to a given frame, we need to
consider the frame's URL and also if the frame is sandboxed. We check the latter
by asking if the frame's security origin is the unique origin. However, we can
only usefully do this in the render process when examining a frame. In the
browser process or other common code, there's no useful origin to use other than
one that duplicates information in the URL.
This does security checks in the render process before doing any URL-based
lookups and then uses URLs from that point on.
R=abarth, mpcomplete
BUG=259982,237267
Review URL: https://chromiumcodereview.appspot.com/16625012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212302 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/extensions/navigation_observer.cc')
-rw-r--r-- | chrome/browser/extensions/navigation_observer.cc | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/chrome/browser/extensions/navigation_observer.cc b/chrome/browser/extensions/navigation_observer.cc index f8030e9..3e3bde3 100644 --- a/chrome/browser/extensions/navigation_observer.cc +++ b/chrome/browser/extensions/navigation_observer.cc @@ -59,7 +59,7 @@ void NavigationObserver::PromptToEnableExtensionIfNecessary( ExtensionService* extension_service = extensions::ExtensionSystem::Get(profile_)->extension_service(); const Extension* extension = extension_service->disabled_extensions()-> - GetExtensionOrAppByURL(ExtensionURLInfo(nav_entry->GetURL())); + GetExtensionOrAppByURL(nav_entry->GetURL()); if (!extension) return; |