diff options
| author | andybons@chromium.org <andybons@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-11-24 01:28:41 +0000 |
|---|---|---|
| committer | andybons@chromium.org <andybons@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-11-24 01:28:41 +0000 |
| commit | 3400467bb7612df3a77de94e6acca532f85abd5c (patch) | |
| tree | 28fe9363e363ac032c39dea72020306264cc556f /chrome/browser/extensions/pack_extension_job.h | |
| parent | 6ac0844d6ba66338848f3a461d3f540da7b6f5dc (diff) | |
| download | chromium_src-3400467bb7612df3a77de94e6acca532f85abd5c.zip chromium_src-3400467bb7612df3a77de94e6acca532f85abd5c.tar.gz chromium_src-3400467bb7612df3a77de94e6acca532f85abd5c.tar.bz2 | |
Fixes extension packing codepath that was hitting a race condition DCHECK described in http://crbug.com/27944.
BUG=28530
TEST=Open chrome://extensions, select 'Pack Extension', select an extension folder, press OK. Should pack the extension instead of crash.
Review URL: http://codereview.chromium.org/436008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32898 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/extensions/pack_extension_job.h')
| -rw-r--r-- | chrome/browser/extensions/pack_extension_job.h | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/chrome/browser/extensions/pack_extension_job.h b/chrome/browser/extensions/pack_extension_job.h index 8c008d9..2ad95a6 100644 --- a/chrome/browser/extensions/pack_extension_job.h +++ b/chrome/browser/extensions/pack_extension_job.h @@ -29,6 +29,10 @@ class PackExtensionJob : public base::RefCountedThreadSafe<PackExtensionJob> { const FilePath& root_directory, const FilePath& key_file); + // Starts the packing thread job. See http://crbug.com/27944 for more details + // on why this function is needed. + void Start(); + // The client should call this when it is destroyed to prevent // PackExtensionJob from attempting to access it. void ClearClient(); |