diff options
| author | skerner@chromium.org <skerner@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-04-20 15:03:55 +0000 |
|---|---|---|
| committer | skerner@chromium.org <skerner@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-04-20 15:03:55 +0000 |
| commit | 264fda93befd14308dc1703b53c270cbe63e8dc6 (patch) | |
| tree | dc90bd18d77784ed1eeef9f6fe55092a0d1321ab /chrome/browser/extensions/sandboxed_extension_unpacker.h | |
| parent | 3734583c76f98e44719b3eda031406321a2ca394 (diff) | |
| download | chromium_src-264fda93befd14308dc1703b53c270cbe63e8dc6.zip chromium_src-264fda93befd14308dc1703b53c270cbe63e8dc6.tar.gz chromium_src-264fda93befd14308dc1703b53c270cbe63e8dc6.tar.bz2 | |
Add histograms that measure unpack time.
These histograms should allow us to decide if a UI for unpack progress will be necessary. We will have to extrapolate for small extensions to larger ones.
For example, if extensions in the 1-2 MB range take a second to unpack, and 2-3 MB takes two seconds, then we can guess that 100MB extensions will take over a minute, so a UI is clearly needed.
BUG=None
TEST=Manual: Install a few extensions, look at about:histogram
Review URL: http://codereview.chromium.org/6875008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82289 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/extensions/sandboxed_extension_unpacker.h')
| -rw-r--r-- | chrome/browser/extensions/sandboxed_extension_unpacker.h | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/chrome/browser/extensions/sandboxed_extension_unpacker.h b/chrome/browser/extensions/sandboxed_extension_unpacker.h index 5d698d7..2857581 100644 --- a/chrome/browser/extensions/sandboxed_extension_unpacker.h +++ b/chrome/browser/extensions/sandboxed_extension_unpacker.h @@ -118,7 +118,7 @@ class SandboxedExtensionUnpacker : public UtilityProcessHost::Client { COULD_NOT_LOCALIZE_EXTENSION, INVALID_MANIFEST, - //SandboxedExtensionUnpacker::OnUnpackExtensionFailed() + // SandboxedExtensionUnpacker::OnUnpackExtensionFailed() UNPACKER_CLIENT_FAILED, // SandboxedExtensionUnpacker::OnProcessCrashed() @@ -226,6 +226,9 @@ class SandboxedExtensionUnpacker : public UtilityProcessHost::Client { // The public key that was extracted from the CRX header. std::string public_key_; + + // Time at which unpacking started. Used to compute the time unpacking takes. + base::TimeTicks unpack_start_time_; }; #endif // CHROME_BROWSER_EXTENSIONS_SANDBOXED_EXTENSION_UNPACKER_H_ |