Extensions: file handling clean up.

- remove various invalid uses of ASCII functions
- properly escape resource requests
- clean up file path handling

Some work remains to be done on the last bullet point but this is enough to fix the bug.

BUG=30509
TEST=see bug

Review URL: http://codereview.chromium.org/501046

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34923 0039d316-1c4b-4281-b951-d872f2087c98

1 files changed, 3 insertions, 4 deletions

diff --git a/chrome/browser/extensions/sandboxed_extension_unpacker_unittest.cc b/chrome/browser/extensions/sandboxed_extension_unpacker_unittest.cc
index f48da5d..3212080 100644
--- a/chrome/browser/extensions/sandboxed_extension_unpacker_unittest.cc
+++ b/chrome/browser/extensions/sandboxed_extension_unpacker_unittest.cc
@@ -128,7 +128,7 @@ TEST_F(SandboxedExtensionUnpackerTest, NoCatalogsSuccess) {
 
   // Check that there is no _locales folder.
   FilePath install_path =
-    GetInstallPath().AppendASCII(Extension::kLocaleFolder);
+    GetInstallPath().Append(Extension::kLocaleFolder);
   EXPECT_FALSE(file_util::PathExists(install_path));
 
   OnUnpackSucceeded();
@@ -146,10 +146,9 @@ TEST_F(SandboxedExtensionUnpackerTest, WithCatalogsSuccess) {
 
   // Check timestamp on _locales/en_US/messages.json.
   FilePath messages_file;
-  messages_file = GetInstallPath()
-      .AppendASCII(Extension::kLocaleFolder)
+  messages_file = GetInstallPath().Append(Extension::kLocaleFolder)
       .AppendASCII("en_US")
-      .AppendASCII(Extension::kMessagesFilename);
+      .Append(Extension::kMessagesFilename);
   file_util::FileInfo old_info;
   EXPECT_TRUE(file_util::GetFileInfo(messages_file, &old_info));