diff options
| author | msw@chromium.org <msw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-03-17 23:02:20 +0000 |
|---|---|---|
| committer | msw@chromium.org <msw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-03-17 23:02:20 +0000 |
| commit | bc6431ccc1c076a404a6aa6747ed8183f4e0943e (patch) | |
| tree | bf7ce0cbd9896342560313fccc0ee4c76656a8e2 /chrome/browser/extensions/startup_helper.h | |
| parent | 8b38988b9820041f31fb0af6a9dd19acdaafe7b1 (diff) | |
| download | chromium_src-bc6431ccc1c076a404a6aa6747ed8183f4e0943e.zip chromium_src-bc6431ccc1c076a404a6aa6747ed8183f4e0943e.tar.gz chromium_src-bc6431ccc1c076a404a6aa6747ed8183f4e0943e.tar.bz2 | |
Reduce user-data-dir crashes; warn and exit if possible.
Only init the user-data-dir as needed.
Warn and exit on browser startup, don't crash.
Warn with the default dir if PathService fails.
(Get fails when that dir can't be created)
TODO(followup): Fix IsFirstRunSentinelPresent paths.
(ignores --user-data-dir switches, policy)
(DCHECKs even with a good override dir)
TODO(followup): PathService::Get behavior change.
(return paths that it cannot create with false/error)
TODO(followup): Handle existing, inaccessible dirs.
(see description at <http://crbug.com/349899#c3>)
BUG=349899,345025,345582
TEST=fewer user-data-dir related crashes, more warning dialogs, especially when the browser process is launched without access privileges to the parent of the default user-data-dir (mixed account uses, launching as service(?), etc.); see the bug. Does not regress issue 345025 nor issue 345582.
R=cpu@chromium.org, gab@chromium.org, sky@chromium.org
Review URL: https://codereview.chromium.org/180723025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257512 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/extensions/startup_helper.h')
0 files changed, 0 insertions, 0 deletions