Stop using weak v8 references to keep track of inline install callbacks.

The callback function(s) need to be kept alive until installation suceeds or
fails. Switch to using an explicit map (implemented in the JS bindings) instead.

This was a problem from the start, but wasn't uncovered in tests until r120621
landed, since (presumably) it keeps the renderer process alive longer, thus making
it more likely to do a GC between chrome.webstore.install being called and the
callbacks being invoked.

To make implementing all of this easier, change the bindings to use
ChromeV8Extension and ChromeV8ExtensionHandler, so that we can use chromeHidden
to reach the response function.

BUG=113024
R=aa@chromium.org


Review URL: http://codereview.chromium.org/9361017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@121606 0039d316-1c4b-4281-b951-d872f2087c98

1 files changed, 4 insertions, 2 deletions

diff --git a/chrome/browser/extensions/webstore_inline_installer.cc b/chrome/browser/extensions/webstore_inline_installer.cc
index ce1aab6..e28e59e 100644
--- a/chrome/browser/extensions/webstore_inline_installer.cc
+++ b/chrome/browser/extensions/webstore_inline_installer.cc
@@ -146,11 +146,13 @@ class SafeWebstoreResponseParser : public UtilityProcessHostClient {
 
 WebstoreInlineInstaller::WebstoreInlineInstaller(WebContents* web_contents,
                                                  int install_id,
+                                                 int return_route_id,
                                                  std::string webstore_item_id,
                                                  GURL requestor_url,
                                                  Delegate* delegate)
     : content::WebContentsObserver(web_contents),
       install_id_(install_id),
+      return_route_id_(return_route_id),
       id_(webstore_item_id),
       requestor_url_(requestor_url),
       delegate_(delegate),
@@ -446,9 +448,9 @@ void WebstoreInlineInstaller::CompleteInstall(const std::string& error) {
   // response to.
   if (web_contents()) {
     if (error.empty()) {
-      delegate_->OnInlineInstallSuccess(install_id_);
+      delegate_->OnInlineInstallSuccess(install_id_, return_route_id_);
     } else {
-      delegate_->OnInlineInstallFailure(install_id_, error);
+      delegate_->OnInlineInstallFailure(install_id_, return_route_id_, error);
     }
   }