diff options
author | szym@chromium.org <szym@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-04-22 15:44:26 +0000 |
---|---|---|
committer | szym@chromium.org <szym@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-04-22 15:44:26 +0000 |
commit | 79bac42a3f1ac9ea2466c6b99ebf6a58a1e21e64 (patch) | |
tree | d404efceaaee45989c09631e68b4becf45eba18a /chrome/browser/extensions/webstore_standalone_installer.h | |
parent | f637b85dab565e532fc333daf932b9889abea2b5 (diff) | |
download | chromium_src-79bac42a3f1ac9ea2466c6b99ebf6a58a1e21e64.zip chromium_src-79bac42a3f1ac9ea2466c6b99ebf6a58a1e21e64.tar.gz chromium_src-79bac42a3f1ac9ea2466c6b99ebf6a58a1e21e64.tar.bz2 |
Revert 195501 "Make UserManager a non-Lazy singleton"
ASAN found heap-use-after-free:
ObserverListBase<policy::DeviceLocalAccountPolicyService::Observer>::RemoveObserver
chromeos::UserManagerImpl::Shutdown
chromeos::ScopedTestUserManager::~ScopedTestUserManager
...
chromeos::(anonymous namespace)::LoginUtilsTest::~LoginUtilsTest
> Make UserManager a non-Lazy singleton
>
> This CL turns the UserManager from a LazyInstance singleton with an
> unpredictable lifetime into a singleton that is explicity instantiated
> and torn down at well-defined points in the browser's lifetime.
>
> BUG=None
>
> For tests that need to instantiate a UserManager now:
> TBR=oshima,hashimoto,mnissler,benwells,davemoore,pkotwicz,sky
>
> Review URL: https://chromiumcodereview.appspot.com/14362029
TBR=bartfab@chromium.org
Review URL: https://codereview.chromium.org/13842020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195509 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/extensions/webstore_standalone_installer.h')
0 files changed, 0 insertions, 0 deletions