diff options
| author | brettw@chromium.org <brettw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-04-28 06:52:35 +0000 |
|---|---|---|
| committer | brettw@chromium.org <brettw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-04-28 06:52:35 +0000 |
| commit | 329581b6dbfa4ad0ca1013d0407e202b8dffed77 (patch) | |
| tree | 8a6832ac64e99760cb07b74a08896f7a41def051 /chrome/browser/extensions | |
| parent | 6faa0e0d23ca6fc27ae603063ce23eb018a670cd (diff) | |
| download | chromium_src-329581b6dbfa4ad0ca1013d0407e202b8dffed77.zip chromium_src-329581b6dbfa4ad0ca1013d0407e202b8dffed77.tar.gz chromium_src-329581b6dbfa4ad0ca1013d0407e202b8dffed77.tar.bz2 | |
Synchronously update the loading state when a load starts so that the UI will
be more responsive and the loading state won't be out-of-sync with anything
else. This also removes the synchronous update to the throbber when we load a
URL because this happens before the loda actually starts, giving a flash of the
default favicon. The load start call made by RenderViewHost will cover this
case after the load actually starts.
BUG=11051
Review URL: http://codereview.chromium.org/100033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14718 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/extensions')
| -rwxr-xr-x | chrome/browser/extensions/extension_view.cc | 6 | ||||
| -rwxr-xr-x | chrome/browser/extensions/extension_view.h | 6 |
2 files changed, 4 insertions, 8 deletions
diff --git a/chrome/browser/extensions/extension_view.cc b/chrome/browser/extensions/extension_view.cc index 2332886..b394af7 100755 --- a/chrome/browser/extensions/extension_view.cc +++ b/chrome/browser/extensions/extension_view.cc @@ -60,8 +60,7 @@ void ExtensionView::SetBackground(const SkBitmap& background) { ShowIfCompletelyLoaded(); } -void ExtensionView::DidStopLoading(RenderViewHost* render_view_host, - int32 page_id) { +void ExtensionView::DidStopLoading(RenderViewHost* render_view_host) { render_view_host->WasResized(); did_stop_loading_ = true; ShowIfCompletelyLoaded(); @@ -118,8 +117,7 @@ void ExtensionView::RunJavaScriptMessage( render_view_host()->JavaScriptMessageBoxClosed(reply_msg, true, L""); } -void ExtensionView::DidStartLoading(RenderViewHost* render_view_host, - int32 page_id) { +void ExtensionView::DidStartLoading(RenderViewHost* render_view_host) { static const StringPiece toolstrip_css( ResourceBundle::GetSharedInstance().GetRawDataResource( IDR_EXTENSIONS_TOOLSTRIP_CSS)); diff --git a/chrome/browser/extensions/extension_view.h b/chrome/browser/extensions/extension_view.h index 429f89f..38e093d 100755 --- a/chrome/browser/extensions/extension_view.h +++ b/chrome/browser/extensions/extension_view.h @@ -53,8 +53,7 @@ class ExtensionView : public HWNDHtmlView, const std::string& extension_id); virtual void RenderViewCreated(RenderViewHost* render_view_host); virtual void DidContentsPreferredWidthChange(const int pref_width); - virtual void DidStopLoading(RenderViewHost* render_view_host, - int32 page_id); + virtual void DidStopLoading(RenderViewHost* render_view_host); virtual WebPreferences GetWebkitPrefs(); virtual void RunJavaScriptMessage( const std::wstring& message, @@ -63,8 +62,7 @@ class ExtensionView : public HWNDHtmlView, const int flags, IPC::Message* reply_msg, bool* did_suppress_message); - virtual void DidStartLoading(RenderViewHost* render_view_host, - int32 page_id); + virtual void DidStartLoading(RenderViewHost* render_view_host); virtual RenderViewHostDelegate::View* GetViewDelegate() const; // RenderViewHostDelegate::View |