summaryrefslogtreecommitdiffstats
path: root/chrome/browser/extensions
diff options
context:
space:
mode:
authorfinnur@chromium.org <finnur@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2010-01-06 00:27:54 +0000
committerfinnur@chromium.org <finnur@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2010-01-06 00:27:54 +0000
commita198044ef95f0f3a013e86bd568577d40124a464 (patch)
tree85a34dba4210c66de8fcb671d414761ba8789317 /chrome/browser/extensions
parent690d0a9175790c4bd3abd066932bc08203c164ca (diff)
downloadchromium_src-a198044ef95f0f3a013e86bd568577d40124a464.zip
chromium_src-a198044ef95f0f3a013e86bd568577d40124a464.tar.gz
chromium_src-a198044ef95f0f3a013e86bd568577d40124a464.tar.bz2
When RSS feed has no links, show the title (but don't create an anchor).
This used to show up as blank preview. BUG=None TEST=Covered by (new) automatic tests. Review URL: http://codereview.chromium.org/523029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35587 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/extensions')
-rw-r--r--chrome/browser/extensions/extension_browsertests_misc.cc11
1 files changed, 11 insertions, 0 deletions
diff --git a/chrome/browser/extensions/extension_browsertests_misc.cc b/chrome/browser/extensions/extension_browsertests_misc.cc
index ba2af3c..e070cb4 100644
--- a/chrome/browser/extensions/extension_browsertests_misc.cc
+++ b/chrome/browser/extensions/extension_browsertests_misc.cc
@@ -38,6 +38,7 @@ const std::wstring kValidFeed2 = L"files/feeds/feed2.xml";
const std::wstring kValidFeed3 = L"files/feeds/feed3.xml";
const std::wstring kValidFeed4 = L"files/feeds/feed4.xml";
const std::wstring kValidFeed5 = L"files/feeds/feed5.xml";
+const std::wstring kValidFeedNoLinks = L"files/feeds/feed_nolinks.xml";
const std::wstring kInvalidFeed1 = L"files/feeds/feed_invalid1.xml";
const std::wstring kInvalidFeed2 = L"files/feeds/feed_invalid2.xml";
const std::wstring kLocalization =
@@ -482,6 +483,16 @@ IN_PROC_BROWSER_TEST_F(ExtensionBrowserTest, ParseFeedInvalidFeed3) {
"Not a valid feed.");
}
+IN_PROC_BROWSER_TEST_F(ExtensionBrowserTest, ParseFeedValidFeedNoLinks) {
+ HTTPTestServer* server = StartHTTPServer();
+ // Valid feed but containing no links.
+ GetParsedFeedData(server, kValidFeedNoLinks, browser(),
+ "Feed for 'MyFeedTitle'",
+ "Title with no link",
+ "Desc",
+ "No error");
+}
+
// Tests that message passing between extensions and tabs works.
IN_PROC_BROWSER_TEST_F(ExtensionBrowserTest, DISABLED_MessagingExtensionTab) {
ASSERT_TRUE(LoadExtension(