diff options
| author | ziadh@chromium.org <ziadh@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-07-30 20:39:31 +0000 |
|---|---|---|
| committer | ziadh@chromium.org <ziadh@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-07-30 20:39:31 +0000 |
| commit | 1bc6c551f14f237d5d56b18afb87ea1570483c1c (patch) | |
| tree | 3a5b2c22e19d3d06d82580a88754e944d3aac7c3 /chrome/browser/extensions | |
| parent | de1e675607fb3f8fb34f90093f3b9500cf3f2e46 (diff) | |
| download | chromium_src-1bc6c551f14f237d5d56b18afb87ea1570483c1c.zip chromium_src-1bc6c551f14f237d5d56b18afb87ea1570483c1c.tar.gz chromium_src-1bc6c551f14f237d5d56b18afb87ea1570483c1c.tar.bz2 | |
Add undeclared virtual destructors part 3
Preventative maintenance for abstract classes that do not declare virtual
destructors. Base classes that do not declare their destructors as virtual
could potentially lead to memory leaks.
These files were discovered using the -Wnon-virtual-dtor flag in g++.
r=jar
BUG=47469
Review URL: http://codereview.chromium.org/3072010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54373 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/extensions')
| -rw-r--r-- | chrome/browser/extensions/extension_context_menu_model.h | 3 | ||||
| -rw-r--r-- | chrome/browser/extensions/extension_install_ui.h | 3 | ||||
| -rw-r--r-- | chrome/browser/extensions/extension_toolbar_model.h | 3 |
3 files changed, 9 insertions, 0 deletions
diff --git a/chrome/browser/extensions/extension_context_menu_model.h b/chrome/browser/extensions/extension_context_menu_model.h index 49a4bb9..bec8d37 100644 --- a/chrome/browser/extensions/extension_context_menu_model.h +++ b/chrome/browser/extensions/extension_context_menu_model.h @@ -28,6 +28,9 @@ class ExtensionContextMenuModel // Called when the user selects the menu item which requests that the // popup be shown and inspected. virtual void InspectPopup(ExtensionAction* action) = 0; + + protected: + virtual ~PopupDelegate() {} }; // Creates a menu model for the given extension action. If diff --git a/chrome/browser/extensions/extension_install_ui.h b/chrome/browser/extensions/extension_install_ui.h index 08fb3ea..001d0e0 100644 --- a/chrome/browser/extensions/extension_install_ui.h +++ b/chrome/browser/extensions/extension_install_ui.h @@ -48,6 +48,9 @@ class ExtensionInstallUI : public ImageLoadingTracker::Observer { // We call this method after ConfirmInstall()/ConfirmUninstall() to signal // that the installation/uninstallation should stop. virtual void InstallUIAbort() = 0; + + protected: + virtual ~Delegate() {} }; explicit ExtensionInstallUI(Profile* profile); diff --git a/chrome/browser/extensions/extension_toolbar_model.h b/chrome/browser/extensions/extension_toolbar_model.h index 6ea2e3b..028c8b5 100644 --- a/chrome/browser/extensions/extension_toolbar_model.h +++ b/chrome/browser/extensions/extension_toolbar_model.h @@ -36,6 +36,9 @@ class ExtensionToolbarModel : public NotificationObserver { // Called when the model has finished loading. virtual void ModelLoaded() {} + + protected: + virtual ~Observer() {} }; // Functions called by the view. |