diff options
author | ziadh@chromium.org <ziadh@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-07-24 02:47:40 +0000 |
---|---|---|
committer | ziadh@chromium.org <ziadh@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-07-24 02:47:40 +0000 |
commit | 46ebf0640d32b313618fe443a34e959059b2c3f9 (patch) | |
tree | 84b616ce5385bce6c8d4b966e74daf7648fdc8c5 /chrome/browser/extensions | |
parent | 7c543fd101874d1453dfcf9727dd0d39d296ef50 (diff) | |
download | chromium_src-46ebf0640d32b313618fe443a34e959059b2c3f9.zip chromium_src-46ebf0640d32b313618fe443a34e959059b2c3f9.tar.gz chromium_src-46ebf0640d32b313618fe443a34e959059b2c3f9.tar.bz2 |
Add undeclared virtual destructors.
Preventative maintainance for abstract classes that do not declare virtual destructors. Base classes that do not declare their destructors as virtual could potentially lead to memory leaks.
r=jar
Review URL: http://codereview.chromium.org/2856051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53570 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/extensions')
-rw-r--r-- | chrome/browser/extensions/extension_clipboard_api.h | 3 | ||||
-rw-r--r-- | chrome/browser/extensions/extension_infobar_delegate.h | 3 | ||||
-rw-r--r-- | chrome/browser/extensions/pack_extension_job.h | 3 |
3 files changed, 9 insertions, 0 deletions
diff --git a/chrome/browser/extensions/extension_clipboard_api.h b/chrome/browser/extensions/extension_clipboard_api.h index 4789221..d47d50e 100644 --- a/chrome/browser/extensions/extension_clipboard_api.h +++ b/chrome/browser/extensions/extension_clipboard_api.h @@ -14,6 +14,9 @@ class ClipboardFunction : public SyncExtensionFunction { public: virtual bool RunImpl(); virtual bool RunImpl(RenderViewHost* render_view_host) = 0; + + protected: + virtual ~ClipboardFunction() {} }; class ExecuteCopyClipboardFunction : public ClipboardFunction { diff --git a/chrome/browser/extensions/extension_infobar_delegate.h b/chrome/browser/extensions/extension_infobar_delegate.h index 01174ef..2d20d82 100644 --- a/chrome/browser/extensions/extension_infobar_delegate.h +++ b/chrome/browser/extensions/extension_infobar_delegate.h @@ -21,6 +21,9 @@ class ExtensionInfoBarDelegate : public InfoBarDelegate, class DelegateObserver { public: virtual void OnDelegateDeleted() = 0; + + protected: + virtual ~DelegateObserver() {} }; ExtensionInfoBarDelegate(Browser* browser, TabContents* contents, diff --git a/chrome/browser/extensions/pack_extension_job.h b/chrome/browser/extensions/pack_extension_job.h index 2ad95a6..f0d10e1 100644 --- a/chrome/browser/extensions/pack_extension_job.h +++ b/chrome/browser/extensions/pack_extension_job.h @@ -23,6 +23,9 @@ class PackExtensionJob : public base::RefCountedThreadSafe<PackExtensionJob> { virtual void OnPackSuccess(const FilePath& crx_file, const FilePath& key_file) = 0; virtual void OnPackFailure(const std::wstring& message) = 0; + + protected: + virtual ~Client() {} }; PackExtensionJob(Client* client, |