diff options
| author | fangjue23303@gmail.com <fangjue23303@gmail.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-04-06 10:33:22 +0000 |
|---|---|---|
| committer | fangjue23303@gmail.com <fangjue23303@gmail.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-04-06 10:33:22 +0000 |
| commit | 74af23e2a47b1a435f57ff6bf7594c9ec1c2df90 (patch) | |
| tree | e6b59d3241089c7e931fbd119eb8ca1d547c3b65 /chrome/browser/extensions | |
| parent | 5f78f294dbc6e7056c89a24c9635fc82de1078c3 (diff) | |
| download | chromium_src-74af23e2a47b1a435f57ff6bf7594c9ec1c2df90.zip chromium_src-74af23e2a47b1a435f57ff6bf7594c9ec1c2df90.tar.gz chromium_src-74af23e2a47b1a435f57ff6bf7594c9ec1c2df90.tar.bz2 | |
Don't create an extra new tab when calling chrome.windows.create for a popup
Calling chrome.windows.create({type: 'popup'}) without specifying URLs creates a new tab in addition to an empty popup. This CL fixes it.
BUG=226289
Review URL: https://chromiumcodereview.appspot.com/13605004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192738 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/extensions')
| -rw-r--r-- | chrome/browser/extensions/api/tabs/tabs_api.cc | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/chrome/browser/extensions/api/tabs/tabs_api.cc b/chrome/browser/extensions/api/tabs/tabs_api.cc index 2d967b3..d355a07 100644 --- a/chrome/browser/extensions/api/tabs/tabs_api.cc +++ b/chrome/browser/extensions/api/tabs/tabs_api.cc @@ -672,7 +672,8 @@ bool WindowsCreateFunction::RunImpl() { TabStripModel* target_tab_strip = new_window->tab_strip_model(); target_tab_strip->InsertWebContentsAt(urls.size(), contents, TabStripModel::ADD_NONE); - } else if (urls.empty()) { + } else if (urls.empty() && window_type != Browser::TYPE_POPUP) { + // Don't create a new tab when it is intended to create an empty popup. chrome::NewTab(new_window); } chrome::SelectNumberedTab(new_window, 0); |