summaryrefslogtreecommitdiffstats
path: root/chrome/browser/extensions
diff options
context:
space:
mode:
authormpcomplete@chromium.org <mpcomplete@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2009-06-30 19:52:09 +0000
committermpcomplete@chromium.org <mpcomplete@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2009-06-30 19:52:09 +0000
commit4083f0521b25dfe74914421f632d18e87dad4048 (patch)
tree229a8d1e348f86906aa7341a112ad7e7e7e22ce7 /chrome/browser/extensions
parent019acf33272edf63ce3f57469446042c760f924f (diff)
downloadchromium_src-4083f0521b25dfe74914421f632d18e87dad4048.zip
chromium_src-4083f0521b25dfe74914421f632d18e87dad4048.tar.gz
chromium_src-4083f0521b25dfe74914421f632d18e87dad4048.tar.bz2
Refactor extension bindings to share code, avoid exposing hidden variables
globally, and avoid using the DOM load/unload events. - moved callback handling into event_bindings.js (ports will use it). - added chromeHidden, a V8 hidden value, to keep all internal variables that need to be accessible to native code. - changed context registration to occur always at extension load, instead of DOM load. - added an internal unload event that doesn't disable SuddenTermination. This is a rework of my earlier CL http://codereview.chromium.org/125280 which was reverted because of a perf regression. I believe the perf problem was caused by the call into javascript I did on page load to handle context registration - this CL avoids that. Review URL: http://codereview.chromium.org/147033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19634 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/extensions')
-rw-r--r--chrome/browser/extensions/extension_message_service.cc8
1 files changed, 4 insertions, 4 deletions
diff --git a/chrome/browser/extensions/extension_message_service.cc b/chrome/browser/extensions/extension_message_service.cc
index c7d7a50..7a65078 100644
--- a/chrome/browser/extensions/extension_message_service.cc
+++ b/chrome/browser/extensions/extension_message_service.cc
@@ -89,13 +89,13 @@ template <> struct RunnableMethodTraits<ExtensionMessageService> {
const char ExtensionMessageService::kDispatchOnConnect[] =
- "chrome.Port.dispatchOnConnect_";
+ "Port.dispatchOnConnect";
const char ExtensionMessageService::kDispatchOnDisconnect[] =
- "chrome.Port.dispatchOnDisconnect_";
+ "Port.dispatchOnDisconnect";
const char ExtensionMessageService::kDispatchOnMessage[] =
- "chrome.Port.dispatchOnMessage_";
+ "Port.dispatchOnMessage";
const char ExtensionMessageService::kDispatchEvent[] =
- "chrome.Event.dispatchJSON_";
+ "Event.dispatchJSON";
// static
ExtensionMessageService* ExtensionMessageService::GetInstance(