diff options
| author | rafaelw@chromium.org <rafaelw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-11-12 21:41:15 +0000 |
|---|---|---|
| committer | rafaelw@chromium.org <rafaelw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-11-12 21:41:15 +0000 |
| commit | db30527a4f5017945dca3db5cf6cb5e1d589387e (patch) | |
| tree | 22a0c41d138300aa72a7d441620d6dad3eed0440 /chrome/browser/extensions | |
| parent | 99432806a06b73301e4723de2d4b6b12aad63a21 (diff) | |
| download | chromium_src-db30527a4f5017945dca3db5cf6cb5e1d589387e.zip chromium_src-db30527a4f5017945dca3db5cf6cb5e1d589387e.tar.gz chromium_src-db30527a4f5017945dca3db5cf6cb5e1d589387e.tar.bz2 | |
JsonSchema support for declaring "object" constructors.
This adds support for an optional declaration of "isInstanceOf" on "type":"object". If present, the candidate object will be tested for js:instanceof window[schema.isInstanceOf].
Several api functions are modified to take advantage of declaring their "class".
Also, support added to docs for modules, methods & events to declare "nodocs":"true" to be excluded from the docs.
Also, check to warn on an attempt to use cygwin python to generate docs.
BUG=27213
TEST=NONE
Review URL: http://codereview.chromium.org/389005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31834 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/extensions')
| -rw-r--r-- | chrome/browser/extensions/extension_popup_api.cc | 6 |
1 files changed, 1 insertions, 5 deletions
diff --git a/chrome/browser/extensions/extension_popup_api.cc b/chrome/browser/extensions/extension_popup_api.cc index 8ef2fe8..26db2e1 100644 --- a/chrome/browser/extensions/extension_popup_api.cc +++ b/chrome/browser/extensions/extension_popup_api.cc @@ -75,12 +75,8 @@ bool PopupShowFunction::RunImpl() { EXTENSION_FUNCTION_VALIDATE(args_->IsType(Value::TYPE_LIST)); const ListValue* args = args_as_list(); - DictionaryValue* popup_info = NULL; - EXTENSION_FUNCTION_VALIDATE(args->GetDictionary(0, &popup_info)); - std::string url_string; - EXTENSION_FUNCTION_VALIDATE(popup_info->GetString(kUrlKey, - &url_string)); + EXTENSION_FUNCTION_VALIDATE(args->GetString(0, &url_string)); DictionaryValue* dom_anchor = NULL; EXTENSION_FUNCTION_VALIDATE(args->GetDictionary(1, &dom_anchor)); |