Defer app window appearance until first paint.

In order to avoid an ugly flash of white pixels when a new app window is
shown, this patch defers showing a window until a non-empty backing
store update has completed.

The feature is behind the "enable-apps-show-on-first-paint" flag.

BUG=225843, 254152

Review URL: https://codereview.chromium.org/55293003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233422 0039d316-1c4b-4281-b951-d872f2087c98

2 files changed, 3 insertions, 3 deletions

diff --git a/chrome/browser/extensions/api/app_current_window_internal/app_current_window_internal_api.cc b/chrome/browser/extensions/api/app_current_window_internal/app_current_window_internal_api.cc
index ea09a83..044ac48 100644
--- a/chrome/browser/extensions/api/app_current_window_internal/app_current_window_internal_api.cc
+++ b/chrome/browser/extensions/api/app_current_window_internal/app_current_window_internal_api.cc
@@ -108,13 +108,13 @@ bool AppCurrentWindowInternalClearAttentionFunction::RunWithWindow(
 
 bool AppCurrentWindowInternalShowFunction::RunWithWindow(
     ShellWindow* window) {
-  window->GetBaseWindow()->Show();
+  window->Show(ShellWindow::SHOW_ACTIVE);
   return true;
 }
 
 bool AppCurrentWindowInternalHideFunction::RunWithWindow(
     ShellWindow* window) {
-  window->GetBaseWindow()->Hide();
+  window->Hide();
   return true;
 }
 
diff --git a/chrome/browser/extensions/api/app_window/app_window_api.cc b/chrome/browser/extensions/api/app_window/app_window_api.cc
index 671bc71..f03795d 100644
--- a/chrome/browser/extensions/api/app_window/app_window_api.cc
+++ b/chrome/browser/extensions/api/app_window/app_window_api.cc
@@ -179,7 +179,7 @@ bool AppWindowCreateFunction::RunImpl() {
             view_id = created_view->GetRoutingID();
           }
 
-          window->GetBaseWindow()->Show();
+          window->Show(ShellWindow::SHOW_ACTIVE);
           base::DictionaryValue* result = new base::DictionaryValue;
           result->Set("viewId", new base::FundamentalValue(view_id));
           SetCreateResultFromShellWindow(window, result);