diff options
| author | cira@chromium.org <cira@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-06-07 14:00:47 +0000 |
|---|---|---|
| committer | cira@chromium.org <cira@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-06-07 14:00:47 +0000 |
| commit | 7ec0cb21f022b28c20e6e44e5f38f9ed6bc13a16 (patch) | |
| tree | bb5e6ede8f467981bb758ca11cae9f33595a6d22 /chrome/browser/extensions | |
| parent | d8b08c98289cc59828a9f9bef0de16252ef9da18 (diff) | |
| download | chromium_src-7ec0cb21f022b28c20e6e44e5f38f9ed6bc13a16.zip chromium_src-7ec0cb21f022b28c20e6e44e5f38f9ed6bc13a16.tar.gz chromium_src-7ec0cb21f022b28c20e6e44e5f38f9ed6bc13a16.tar.bz2 | |
It seems all RenderView tests have issues. I'll try reverting last significant RenderView change and see if that helps.
Revert 49046 - Disable RenderViewTest.ExtensionMessages* since they consistently crash localy and on the bots.
Code in question didn't change recently (9months) so it is possible it's a WebKit problem.
You need to run all tests to get the crash. Running with --gtest_filter=RenderViewTest.* passes.
There is a possible namespace clash with other RenderViewTest class.
Stack trace:
\src\third_party\WebKit\WebCore\platform\TreeShared.h:38 WebCore::TreeShared<class WebCore::Node>::TreeShared)
Backtrace:
WebCore::TreeShared<WebCore::Node>::TreeShared<WebCore::Node> [0x03AE8EBA+90] (d:\chromium2\src\third_party\webkit\webcore\platform\treeshared.h:38)
WebCore::Node::Node [0x03AD4011+49] (d:\chromium2\src\third_party\webkit\webcore\dom\document.h:1280)
WebCore::ContainerNode::ContainerNode [0x03AD3D7E+30] (d:\chromium2\src\third_party\webkit\webcore\dom\containernode.h:107)
WebCore::Document::Document [0x03AD331A+42] (d:\chromium2\src\third_party\webkit\webcore\dom\document.cpp:403)
WebCore::HTMLDocument::HTMLDocument [0x03DDF76E+30] (d:\chromium2\src\third_party\webkit\webcore\html\htmldocument.cpp:86)
WebCore::HTMLDocument::create [0x03E522B6+54] (d:\chromium2\src\third_party\webkit\webcore\html\htmldocument.h:40)
WebCore::DOMImplementation::createDocument [0x03E52360+112] (d:\chromium2\src\third_party\webkit\webcore\dom\domimplementation.cpp:312)
WebCore::DocumentWriter::createDocument [0x03B9B008+280] (d:\chromium2\src\third_party\webkit\webcore\loader\documentwriter.cpp:88)
WebCore::DocumentWriter::begin [0x03B9B214+52] (d:\chromium2\src\third_party\webkit\webcore\loader\documentwriter.cpp:99)
WebCore::FrameLoader::init [0x03B77539+441] (d:\chromium2\src\third_party\webkit\webcore\loader\frameloader.cpp:251)
WebCore::Frame::init [0x026D4FB9+25] (d:\chromium2\src\third_party\webkit\webcore\page\frame.h:370)
WebKit::WebFrameImpl::initializeAsMainFrame [0x026D4EE6+118] (d:\chromium2\src\third_party\webkit\webkit\chromium\src\webframeimpl.cpp:1712)
WebKit::WebViewImpl::initializeMainFrame [0x0270D1D1+81] (d:\chromium2\src\third_party\webkit\webkit\chromium\src\webviewimpl.cpp:209)
RenderView::Init [0x02BB1C04+660] (d:\chromium2\src\chrome\renderer\render_view.cc:533)
RenderView::Create [0x02BB14CB+267] (d:\chromium2\src\chrome\renderer\render_view.cc:479)
RenderViewTest::SetUp [0x01329E49+841] (d:\chromium2\src\chrome\test\render_view_test.cc:111)
testing::Test::Run [0x02A47DC3+163] (d:\chromium2\src\testing\gtest\src\gtest.cc:2060)
testing::internal::TestInfoImpl::Run [0x02A48B03+339] (d:\chromium2\src\testing\gtest\src\gtest.cc:2318
TBR=cira@chromium.org
Review URL: http://codereview.chromium.org/2698005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49051 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/extensions')
| -rw-r--r-- | chrome/browser/extensions/extension_messages_unittest.cc | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/chrome/browser/extensions/extension_messages_unittest.cc b/chrome/browser/extensions/extension_messages_unittest.cc index 6866973..b90e92f 100644 --- a/chrome/browser/extensions/extension_messages_unittest.cc +++ b/chrome/browser/extensions/extension_messages_unittest.cc @@ -39,7 +39,7 @@ static void DispatchOnMessage(const std::string& message, int source_port_id) { // Tests that the bindings for opening a channel to an extension and sending // and receiving messages through that channel all works. -TEST_F(RenderViewTest, DISABLED_ExtensionMessagesOpenChannel) { +TEST_F(RenderViewTest, ExtensionMessagesOpenChannel) { render_thread_.sink().ClearMessages(); LoadHTML("<body></body>"); ExecuteJavaScript( @@ -86,7 +86,7 @@ TEST_F(RenderViewTest, DISABLED_ExtensionMessagesOpenChannel) { // Tests that the bindings for handling a new channel connection and channel // closing all works. -TEST_F(RenderViewTest, DISABLED_ExtensionMessagesOnConnect) { +TEST_F(RenderViewTest, ExtensionMessagesOnConnect) { LoadHTML("<body></body>"); ExecuteJavaScript( "chrome.extension.onConnect.addListener(function (port) {" |