Window Delegate Improvements:

- Windows now must have a Delegate. Just construct the default WindowDelegate
if
you don't want to have to write one in testing.
- Windows now obtain their contents view by asking the delegate via
WindowDelegate::GetContentsView.
- Contents views no longer need to manually store a pointer to the Window that
contains them, WindowDelegate does this automatically via its window()
accessor.

Reviewer notes:
- review window_delegate.h first, then
- window.h/cc
- custom frame window.h/cc
- constrained_window_impl.h/cc
- then everything else (just updating all call sites)

B=1280060

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96 0039d316-1c4b-4281-b951-d872f2087c98

1 files changed, 5 insertions, 5 deletions

diff --git a/chrome/browser/external_protocol_dialog.cc b/chrome/browser/external_protocol_dialog.cc
index 251a911..e493829 100644
--- a/chrome/browser/external_protocol_dialog.cc
+++ b/chrome/browser/external_protocol_dialog.cc
@@ -105,6 +105,10 @@ bool ExternalProtocolDialog::Accept() {
   return true;
 }
 
+ChromeViews::View* ExternalProtocolDialog::GetContentsView() {
+  return message_box_view_;
+}
+
 ///////////////////////////////////////////////////////////////////////////////
 // ExternalProtocolDialog, private:
 
@@ -135,11 +139,7 @@ ExternalProtocolDialog::ExternalProtocolDialog(TabContents* tab_contents,
     root_hwnd = NULL;
   }
 
-  ChromeViews::Window* dialog =
-      ChromeViews::Window::CreateChromeWindow(root_hwnd, gfx::Rect(),
-                                              message_box_view_, this);
-
-  dialog->Show();
+  ChromeViews::Window::CreateChromeWindow(root_hwnd, gfx::Rect(), this)->Show();
 }
 
 std::wstring ExternalProtocolDialog::GetApplicationForProtocol() {