diff options
| author | ananta@chromium.org <ananta@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-04-08 01:26:07 +0000 |
|---|---|---|
| committer | ananta@chromium.org <ananta@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-04-08 01:26:07 +0000 |
| commit | 9f5b80a726212c9c0a2d0027d1ba71592026c988 (patch) | |
| tree | 9d9e1354527f732deffd961f22a1813d72a6166d /chrome/browser/external_tab_container.cc | |
| parent | 3e0f1a61581c8b4e36339c234348b646a823021b (diff) | |
| download | chromium_src-9f5b80a726212c9c0a2d0027d1ba71592026c988.zip chromium_src-9f5b80a726212c9c0a2d0027d1ba71592026c988.tar.gz chromium_src-9f5b80a726212c9c0a2d0027d1ba71592026c988.tar.bz2 | |
Support the new popup and new window dispositions in the external tab container.
Disabled the TRACK_HWND_DESTRUCTION macro in render_widget_host_view_win.cc as it fires consistently
for the external tab container probably due to multiple WM_DESTROY messages received for the
container, when the parent window is destroyed.
Fixes bug http://b/issue?id=1747547
Bug=1747547
Review URL: http://codereview.chromium.org/63074
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13326 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/external_tab_container.cc')
| -rw-r--r-- | chrome/browser/external_tab_container.cc | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/chrome/browser/external_tab_container.cc b/chrome/browser/external_tab_container.cc index 3ec28a89..521a3bb 100644 --- a/chrome/browser/external_tab_container.cc +++ b/chrome/browser/external_tab_container.cc @@ -7,6 +7,7 @@ #include "base/logging.h" #include "base/win_util.h" #include "chrome/browser/automation/automation_provider.h" +#include "chrome/browser/browser.h" #include "chrome/browser/profile.h" #include "chrome/browser/tab_contents/provisional_load_details.h" #include "chrome/browser/tab_contents/tab_contents.h" @@ -213,6 +214,13 @@ void ExternalTabContainer::AddNewContents(TabContents* source, WindowOpenDisposition disposition, const gfx::Rect& initial_pos, bool user_gesture) { + if (disposition == NEW_POPUP || disposition == NEW_WINDOW) { + Browser::BuildPopupWindowHelper(source, new_contents, initial_pos, + Browser::TYPE_POPUP, + tab_contents_->profile(), true); + } else { + NOTREACHED(); + } } void ExternalTabContainer::ActivateContents(TabContents* contents) { |