diff options
| author | robertshield@google.com <robertshield@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-06-01 15:58:14 +0000 |
|---|---|---|
| committer | robertshield@google.com <robertshield@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-06-01 15:58:14 +0000 |
| commit | 2ff645a2f0f86526d322072ad2ee2305063bcabd (patch) | |
| tree | 69c3f10eeb2afb97379d6803d7aa7db6e028904b /chrome/browser/external_tab_container.cc | |
| parent | d88bf94f6524f7ac27c7d3afa897d6722ffcc894 (diff) | |
| download | chromium_src-2ff645a2f0f86526d322072ad2ee2305063bcabd.zip chromium_src-2ff645a2f0f86526d322072ad2ee2305063bcabd.tar.gz chromium_src-2ff645a2f0f86526d322072ad2ee2305063bcabd.tar.bz2 | |
Re-apply 17223 (http://codereview.chromium.org/115943) to fix external tab handling of certain open dispositions.
Review URL: http://codereview.chromium.org/118030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17315 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/external_tab_container.cc')
| -rw-r--r-- | chrome/browser/external_tab_container.cc | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/chrome/browser/external_tab_container.cc b/chrome/browser/external_tab_container.cc index a8490ae..3a24366 100644 --- a/chrome/browser/external_tab_container.cc +++ b/chrome/browser/external_tab_container.cc @@ -130,7 +130,7 @@ void ExternalTabContainer::SetInitialFocus(bool reverse) { bool ExternalTabContainer::IsExternalTabContainer(HWND window) { if (GetProp(window, kWindowObjectKey) != NULL) return true; - + return false; } @@ -186,7 +186,8 @@ void ExternalTabContainer::AddNewContents(TabContents* source, WindowOpenDisposition disposition, const gfx::Rect& initial_pos, bool user_gesture) { - if (disposition == NEW_POPUP || disposition == NEW_WINDOW) { + if (disposition == NEW_POPUP || disposition == NEW_WINDOW || + disposition == NEW_FOREGROUND_TAB || disposition == NEW_BACKGROUND_TAB) { Browser::BuildPopupWindowHelper(source, new_contents, initial_pos, Browser::TYPE_POPUP, tab_contents_->profile(), true); @@ -235,7 +236,7 @@ void ExternalTabContainer::ToolbarSizeChanged(TabContents* source, void ExternalTabContainer::ForwardMessageToExternalHost( const std::string& message, const std::string& origin, const std::string& target) { - if(automation_) { + if (automation_) { automation_->Send( new AutomationMsg_ForwardMessageToExternalHost(0, tab_handle_, message, origin, target)); |