summaryrefslogtreecommitdiffstats
path: root/chrome/browser/external_tab_container.cc
diff options
context:
space:
mode:
authorbrettw@chromium.org <brettw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2009-02-01 18:16:56 +0000
committerbrettw@chromium.org <brettw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2009-02-01 18:16:56 +0000
commitbfd04a62ce610d7bb61dbb78811dccbed23589b7 (patch)
tree70bb228c0f00ba1c12c584efd569daccf96b4026 /chrome/browser/external_tab_container.cc
parenta814d863440f0a154a7299f2d8b440f405c7700e (diff)
downloadchromium_src-bfd04a62ce610d7bb61dbb78811dccbed23589b7.zip
chromium_src-bfd04a62ce610d7bb61dbb78811dccbed23589b7.tar.gz
chromium_src-bfd04a62ce610d7bb61dbb78811dccbed23589b7.tar.bz2
Remove most header file dependencies on the notification type list. It is
really painful to add more types, since lots of headers include the notification service to derive from the notification observer. This splits that out, so much less of the project should end up including notification_types.h ---Paths modified but not in any changelist: Review URL: http://codereview.chromium.org/19744 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9020 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/external_tab_container.cc')
-rw-r--r--chrome/browser/external_tab_container.cc22
1 files changed, 11 insertions, 11 deletions
diff --git a/chrome/browser/external_tab_container.cc b/chrome/browser/external_tab_container.cc
index 565221d..9527e97 100644
--- a/chrome/browser/external_tab_container.cc
+++ b/chrome/browser/external_tab_container.cc
@@ -83,12 +83,12 @@ bool ExternalTabContainer::Init(Profile* profile, HWND parent,
NavigationController* controller = tab_contents_->controller();
DCHECK(controller);
- registrar_.Add(this, NOTIFY_NAV_ENTRY_COMMITTED,
+ registrar_.Add(this, NotificationType::NAV_ENTRY_COMMITTED,
Source<NavigationController>(controller));
- NotificationService::current()->
- Notify(NOTIFY_EXTERNAL_TAB_CREATED,
- Source<NavigationController>(controller),
- NotificationService::NoDetails());
+ NotificationService::current()->Notify(
+ NotificationType::EXTERNAL_TAB_CREATED,
+ Source<NavigationController>(controller),
+ NotificationService::NoDetails());
// Now apply the parenting and style
if (parent)
@@ -110,10 +110,10 @@ void ExternalTabContainer::OnDestroy() {
NavigationController* controller = tab_contents_->controller();
DCHECK(controller);
- NotificationService::current()->
- Notify(NOTIFY_EXTERNAL_TAB_CLOSED,
- Source<NavigationController>(controller),
- Details<ExternalTabContainer>(this));
+ NotificationService::current()->Notify(
+ NotificationType::EXTERNAL_TAB_CLOSED,
+ Source<NavigationController>(controller),
+ Details<ExternalTabContainer>(this));
tab_contents_->set_delegate(NULL);
tab_contents_->CloseContents();
// WARNING: tab_contents_ has likely been deleted.
@@ -223,8 +223,8 @@ void ExternalTabContainer::ForwardMessageToExternalHost(
void ExternalTabContainer::Observe(NotificationType type,
const NotificationSource& source,
const NotificationDetails& details) {
- switch (type) {
- case NOTIFY_NAV_ENTRY_COMMITTED:
+ switch (type.value) {
+ case NotificationType::NAV_ENTRY_COMMITTED:
if (automation_) {
const NavigationController::LoadCommittedDetails* commit =
Details<NavigationController::LoadCommittedDetails>(details).ptr();