diff options
| author | joshia@google.com <joshia@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2008-08-21 20:34:45 +0000 |
|---|---|---|
| committer | joshia@google.com <joshia@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2008-08-21 20:34:45 +0000 |
| commit | 18cb257530f2a7b6a5d8ce74d3486c1784fcdbf0 (patch) | |
| tree | daa421607577ba79de24e9d9d8c62f60dff60a29 /chrome/browser/external_tab_container.h | |
| parent | 8c026e7a5ab2077eb8381e7b79a78020624a5a64 (diff) | |
| download | chromium_src-18cb257530f2a7b6a5d8ce74d3486c1784fcdbf0.zip chromium_src-18cb257530f2a7b6a5d8ce74d3486c1784fcdbf0.tar.gz chromium_src-18cb257530f2a7b6a5d8ce74d3486c1784fcdbf0.tar.bz2 | |
Code review changes. Incorporated all the suggestions from previous review.
One item not changed yet is to rename 'receiver' in ForwardMessageToExternalHost.
The idea is to invoke receiver("message") at the other end. So for example if the
args to ForwardMessageToExternalHost("hello", "world") then we will invoke a
script hello("world") on the other side.
'receiver' doesn't really describe the first argument here so if there is a
better suggestion, I would be happy to change it :)
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1176 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/external_tab_container.h')
| -rw-r--r-- | chrome/browser/external_tab_container.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/chrome/browser/external_tab_container.h b/chrome/browser/external_tab_container.h index 304d179..8b368dd 100644 --- a/chrome/browser/external_tab_container.h +++ b/chrome/browser/external_tab_container.h @@ -105,8 +105,8 @@ class ExternalTabContainer : public TabContentsDelegate, virtual void ToolbarSizeChanged(TabContents* source, bool is_animating); virtual void DidNavigate(NavigationType nav_type, int relative_navigation_offet); - virtual void SendExternalHostMessage(const std::string& receiver, - const std::string& message); + virtual void ForwardMessageToExternalHost(const std::string& receiver, + const std::string& message); // Notification service callback. |