Reapplying tab support (change 9388). I synced and re-applied my change and found the automation tests not hanging.

I also took a look at the logs from the hanging buildbots and the reverted change didn't touch on any of the code that appeared to be hanging.
I also put breakpoints on the modified functions while running ui_tests.exe and nothing hit, so it looks like a fluke.

I did get a hang though when running an old build of ui_tests.exe with a new version of chrome.dll.
Is there any chance that there could have been a stale version on the build bots?

Review URL: http://codereview.chromium.org/20214

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9478 0039d316-1c4b-4281-b951-d872f2087c98

1 files changed, 5 insertions, 0 deletions

diff --git a/chrome/browser/external_tab_container.h b/chrome/browser/external_tab_container.h
index b09f032..89e2a02 100644
--- a/chrome/browser/external_tab_container.h
+++ b/chrome/browser/external_tab_container.h
@@ -39,6 +39,7 @@ class ExternalTabContainer : public TabContentsDelegate,
  public:
   BEGIN_MSG_MAP(ExternalTabContainer)
     MESSAGE_HANDLER(WM_SIZE, OnSize)
+    MESSAGE_HANDLER(WM_SETFOCUS, OnSetFocus)
     MSG_WM_DESTROY(OnDestroy)
   END_MSG_MAP()
 
@@ -114,6 +115,9 @@ class ExternalTabContainer : public TabContentsDelegate,
   // message it did not process
   void ProcessUnhandledAccelerator(const MSG& msg);
 
+  // See TabContents::SetInitialFocus	
+  void SetInitialFocus(bool reverse);
+
   // A helper method that tests whether the given window is an
   // ExternalTabContainer window
   static bool IsExternalTabContainer(HWND window);
@@ -124,6 +128,7 @@ class ExternalTabContainer : public TabContentsDelegate,
 
  protected:
   LRESULT OnSize(UINT, WPARAM, LPARAM, BOOL& handled);
+  LRESULT OnSetFocus(UINT msg, WPARAM wp, LPARAM lp, BOOL& handled);
   void OnDestroy();
   void OnFinalMessage(HWND window);