diff options
| author | stevenjb@google.com <stevenjb@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-10-06 16:49:16 +0000 |
|---|---|---|
| committer | stevenjb@google.com <stevenjb@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-10-06 16:49:16 +0000 |
| commit | 1b74d2120db778a1809ddb5ca395e149d75e68f2 (patch) | |
| tree | 35f7c3b6b8010316d6211e38793d5b4016315642 /chrome/browser/external_tab_container_win.cc | |
| parent | 7c44ec5eac469803e7531e7e604673e536d50753 (diff) | |
| download | chromium_src-1b74d2120db778a1809ddb5ca395e149d75e68f2.zip chromium_src-1b74d2120db778a1809ddb5ca395e149d75e68f2.tar.gz chromium_src-1b74d2120db778a1809ddb5ca395e149d75e68f2.tar.bz2 | |
chromium-os:7243: Fix so that extensions create popup windows of TYPE_APP_POPUP.
Refactor Browser::BuildPopupWindow as Browser::CreatePopupWindow
and call it from ExtensionHost::ShowCreatedWindow.
BUG=http://code.google.com/p/chromium-os/issues/detail?id=7243
TEST=Test popup windows in general. See issue for specific test case.
Review URL: http://codereview.chromium.org/3532011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61657 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/external_tab_container_win.cc')
| -rw-r--r-- | chrome/browser/external_tab_container_win.cc | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/chrome/browser/external_tab_container_win.cc b/chrome/browser/external_tab_container_win.cc index e591f94..a1e3dd2 100644 --- a/chrome/browser/external_tab_container_win.cc +++ b/chrome/browser/external_tab_container_win.cc @@ -627,7 +627,8 @@ void ExternalTabContainer::HandleKeyboardEvent( void ExternalTabContainer::ShowHtmlDialog(HtmlDialogUIDelegate* delegate, gfx::NativeWindow parent_window) { if (!browser_.get()) { - browser_.reset(Browser::CreateForPopup(tab_contents_->profile())); + browser_.reset(Browser::CreateForType(Browser::TYPE_POPUP, + tab_contents_->profile())); } gfx::NativeWindow parent = parent_window ? parent_window @@ -1066,4 +1067,3 @@ void TemporaryPopupExternalTabContainer::OpenURLFromTab( // support only one navigation for a dummy tab before it is killed. ::DestroyWindow(GetNativeView()); } - |