diff options
| author | kmadhusu@chromium.org <kmadhusu@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-04-05 23:28:10 +0000 |
|---|---|---|
| committer | kmadhusu@chromium.org <kmadhusu@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-04-05 23:28:10 +0000 |
| commit | 92c8a60f72634bd5ceb8cf72aa7ddf2ea689fbeb (patch) | |
| tree | 5fe96fe0cc292aa70296d4848bf7f0d71f91b907 /chrome/browser/favicon | |
| parent | 961f42c5830f4ddff5c42c04b92c1bde4031794f (diff) | |
| download | chromium_src-92c8a60f72634bd5ceb8cf72aa7ddf2ea689fbeb.zip chromium_src-92c8a60f72634bd5ceb8cf72aa7ddf2ea689fbeb.tar.gz chromium_src-92c8a60f72634bd5ceb8cf72aa7ddf2ea689fbeb.tar.bz2 | |
[Coverity] Fix pass by value error in FaviconUtil::SelectFaviconFramesFromPNGs().
CID=105999
BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/13358002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192648 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/favicon')
| -rw-r--r-- | chrome/browser/favicon/favicon_util.cc | 2 | ||||
| -rw-r--r-- | chrome/browser/favicon/favicon_util.h | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/chrome/browser/favicon/favicon_util.cc b/chrome/browser/favicon/favicon_util.cc index c700d98..46b3bd6 100644 --- a/chrome/browser/favicon/favicon_util.cc +++ b/chrome/browser/favicon/favicon_util.cc @@ -103,7 +103,7 @@ std::vector<ui::ScaleFactor> FaviconUtil::GetFaviconScaleFactors() { // static gfx::Image FaviconUtil::SelectFaviconFramesFromPNGs( const std::vector<history::FaviconBitmapResult>& png_data, - const std::vector<ui::ScaleFactor> scale_factors, + const std::vector<ui::ScaleFactor>& scale_factors, int favicon_size) { // Create image reps for as many scale factors as possible without resizing // the bitmap data or decoding it. FaviconHandler stores already resized diff --git a/chrome/browser/favicon/favicon_util.h b/chrome/browser/favicon/favicon_util.h index 91839f7..8e08299 100644 --- a/chrome/browser/favicon/favicon_util.h +++ b/chrome/browser/favicon/favicon_util.h @@ -36,7 +36,7 @@ class FaviconUtil { // a favicon of size favicon_size (in DIPs) at the desired ui scale factors. static gfx::Image SelectFaviconFramesFromPNGs( const std::vector<history::FaviconBitmapResult>& png_data, - const std::vector<ui::ScaleFactor> scale_factors, + const std::vector<ui::ScaleFactor>& scale_factors, int favicon_size); // Takes a vector of bitmaps and returns the index of the image that will best |