diff options
author | Daniel Cheng <dcheng@chromium.org> | 2014-10-21 02:51:29 -0700 |
---|---|---|
committer | Daniel Cheng <dcheng@chromium.org> | 2014-10-21 09:52:23 +0000 |
commit | a542fca3ccd35033c2065fa3e7bed1247043b377 (patch) | |
tree | be0ed153cb1645a1bf02eb1ad1bb9b428cd4c722 /chrome/browser/file_select_helper.h | |
parent | 716bedf160f4c4c1945cab54c3f490424a0eb779 (diff) | |
download | chromium_src-a542fca3ccd35033c2065fa3e7bed1247043b377.zip chromium_src-a542fca3ccd35033c2065fa3e7bed1247043b377.tar.gz chromium_src-a542fca3ccd35033c2065fa3e7bed1247043b377.tar.bz2 |
Standardize usage of virtual/override/final in chrome/browser/
BUG=417463
TBR=jochen@chromium.org
Review URL: https://codereview.chromium.org/648653003
Cr-Commit-Position: refs/heads/master@{#300440}
Diffstat (limited to 'chrome/browser/file_select_helper.h')
-rw-r--r-- | chrome/browser/file_select_helper.h | 35 |
1 files changed, 18 insertions, 17 deletions
diff --git a/chrome/browser/file_select_helper.h b/chrome/browser/file_select_helper.h index 961878a..c94e411 100644 --- a/chrome/browser/file_select_helper.h +++ b/chrome/browser/file_select_helper.h @@ -51,7 +51,7 @@ class FileSelectHelper FRIEND_TEST_ALL_PREFIXES(FileSelectHelperTest, IsAcceptTypeValid); FRIEND_TEST_ALL_PREFIXES(FileSelectHelperTest, ZipPackage); explicit FileSelectHelper(Profile* profile); - virtual ~FileSelectHelper(); + ~FileSelectHelper() override; // Utility class which can listen for directory lister events and relay // them to the main object with the correct tracking id. @@ -61,10 +61,11 @@ class FileSelectHelper DirectoryListerDispatchDelegate(FileSelectHelper* parent, int id) : parent_(parent), id_(id) {} - virtual ~DirectoryListerDispatchDelegate() {} - virtual void OnListFile( + ~DirectoryListerDispatchDelegate() override {} + void OnListFile( const net::DirectoryLister::DirectoryListerData& data) override; - virtual void OnListDone(int error) override; + void OnListDone(int error) override; + private: // This FileSelectHelper owns this object. FileSelectHelper* parent_; @@ -86,23 +87,23 @@ class FileSelectHelper void RunFileChooserEnd(); // SelectFileDialog::Listener overrides. - virtual void FileSelected( - const base::FilePath& path, int index, void* params) override; - virtual void FileSelectedWithExtraInfo( - const ui::SelectedFileInfo& file, - int index, - void* params) override; - virtual void MultiFilesSelected(const std::vector<base::FilePath>& files, - void* params) override; - virtual void MultiFilesSelectedWithExtraInfo( + void FileSelected(const base::FilePath& path, + int index, + void* params) override; + void FileSelectedWithExtraInfo(const ui::SelectedFileInfo& file, + int index, + void* params) override; + void MultiFilesSelected(const std::vector<base::FilePath>& files, + void* params) override; + void MultiFilesSelectedWithExtraInfo( const std::vector<ui::SelectedFileInfo>& files, void* params) override; - virtual void FileSelectionCanceled(void* params) override; + void FileSelectionCanceled(void* params) override; // content::NotificationObserver overrides. - virtual void Observe(int type, - const content::NotificationSource& source, - const content::NotificationDetails& details) override; + void Observe(int type, + const content::NotificationSource& source, + const content::NotificationDetails& details) override; void EnumerateDirectory(int request_id, content::RenderViewHost* render_view_host, |