diff options
| author | finnur@chromium.org <finnur@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-05-05 02:40:07 +0000 |
|---|---|---|
| committer | finnur@chromium.org <finnur@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-05-05 02:40:07 +0000 |
| commit | 126f4120902008da93759d7256c87e1e6d3ae70b (patch) | |
| tree | ba664f25a7d09be02fc6c05802b938fba53683be /chrome/browser/find_bar_controller.cc | |
| parent | 627f02642ffe7075b567ee85e77044d64d72e24d (diff) | |
| download | chromium_src-126f4120902008da93759d7256c87e1e6d3ae70b.zip chromium_src-126f4120902008da93759d7256c87e1e6d3ae70b.tar.gz chromium_src-126f4120902008da93759d7256c87e1e6d3ae70b.tar.bz2 | |
FindBarView::UpdateForResult is not a good place to
beep if nothing was found on the page. The reason is
that it is gets called when you switch from one tab
to the other. I've added a function to FindBar that
the controller can call and each platform can
implement whatever sound they want to use.
BUG=10823
TEST=Open google.com, search for z0, it should beep
(no matches). Open new tab, switch back to the old
tab and it should not beep.
Review URL: http://codereview.chromium.org/99372
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15269 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/find_bar_controller.cc')
| -rw-r--r-- | chrome/browser/find_bar_controller.cc | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/chrome/browser/find_bar_controller.cc b/chrome/browser/find_bar_controller.cc index 07cd5e6..2d273f1 100644 --- a/chrome/browser/find_bar_controller.cc +++ b/chrome/browser/find_bar_controller.cc @@ -121,6 +121,7 @@ void FindBarController::Observe(NotificationType type, if (Source<TabContents>(source).ptr() == tab_contents_) { find_bar_->UpdateUIForFindResult(tab_contents_->find_result(), tab_contents_->find_text()); + find_bar_->AudibleAlertIfNotFound(tab_contents_->find_result()); } } else if (type == NotificationType::NAV_ENTRY_COMMITTED) { NavigationController* source_controller = |