diff options
| author | finnur@chromium.org <finnur@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-03-18 14:59:35 +0000 |
|---|---|---|
| committer | finnur@chromium.org <finnur@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-03-18 14:59:35 +0000 |
| commit | 6b1831a453e6978482bf29da9185150352c8c7f7 (patch) | |
| tree | 758127612ba660f1e80068d6a28e4812605b2b29 /chrome/browser/find_bar_controller.cc | |
| parent | f6d3e11d42746c43869f9c3066ca60d585489cd0 (diff) | |
| download | chromium_src-6b1831a453e6978482bf29da9185150352c8c7f7.zip chromium_src-6b1831a453e6978482bf29da9185150352c8c7f7.tar.gz chromium_src-6b1831a453e6978482bf29da9185150352c8c7f7.tar.bz2 | |
Fixing a few minor issues found during static analysis of the Chromium codebase.
find_bar_controller.cc:
Unused local variable created.
hwnd_view.cc:
The local definition of parent overshadows param passed in.
google_update.cc:
Uninitialized member variable.
webframe_impl.cc:
The if was overly constrained. At the top of the function there is an if (reset) { ... return; } so we don't need to check for !reset in the next if statement. This functionality is covered by a ui_test, which passes with this change.
Review URL: http://codereview.chromium.org/42321
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11964 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/find_bar_controller.cc')
| -rw-r--r-- | chrome/browser/find_bar_controller.cc | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/chrome/browser/find_bar_controller.cc b/chrome/browser/find_bar_controller.cc index 81e759b..c9c6d51 100644 --- a/chrome/browser/find_bar_controller.cc +++ b/chrome/browser/find_bar_controller.cc @@ -114,7 +114,6 @@ void FindBarController::Observe(NotificationType type, if (Source<TabContents>(source).ptr() == web_contents_) { find_bar_->UpdateUIForFindResult(web_contents_->find_result(), web_contents_->find_text()); - FindNotificationDetails details = web_contents_->find_result(); } } else if (type == NotificationType::NAV_ENTRY_COMMITTED) { NavigationController* source_controller = |