The find bar should be owned and managed from the BrowserView, not the WebContentsView, since it's part of the "chrome".

Design Doc: http://dev.chromium.org/developers/design-documents/find-bar

Things done:
- Pulled all of the find bar stuff out of WebContentsView* since it's no longer needed.
- Moved OnFindReply delegate method from RenderViewHostDelegate::View to RenderViewHostDelegate, since it's no longer implemented on the view.
- Moved find control methods to WebContents.
- Added recent find result state to WebContents.
- Updated the UI tests to accommodate the changes in the state that is broadcast when results are discovered.
- Updated the find bar layout to obtain its bounding box from the BrowserView, which knows about toolbars, bookmark bars etc.
- Updated the find bar itself to handle the fact that it can be displayed for multiple different tabs.
- Moved the find bar manipulation methods for testing from TabProxy to BrowserProxy, since the find bar is now a feature of the window, not the tab.
- view.h: Don't lay out child views again if they have a layout manager, it already updated them.

TEST=Find box should work as before.
BUG=3245

Review URL: http://codereview.chromium.org/27025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10231 0039d316-1c4b-4281-b951-d872f2087c98

1 files changed, 9 insertions, 8 deletions

diff --git a/chrome/browser/find_notification_details.h b/chrome/browser/find_notification_details.h
index 23033ae..45dd331 100644
--- a/chrome/browser/find_notification_details.h
+++ b/chrome/browser/find_notification_details.h
@@ -2,8 +2,8 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#ifndef CHROME_BROWSER_FIND_NOTIFICATION_DETAILS_H__
-#define CHROME_BROWSER_FIND_NOTIFICATION_DETAILS_H__
+#ifndef CHROME_BROWSER_FIND_NOTIFICATION_DETAILS_H_
+#define CHROME_BROWSER_FIND_NOTIFICATION_DETAILS_H_
 
 #include "base/basictypes.h"
 #include "base/gfx/rect.h"
@@ -21,6 +21,12 @@ class FindNotificationDetails {
       active_match_ordinal_(active_match_ordinal),
       final_update_(final_update) {}
 
+  FindNotificationDetails()
+    : request_id_(0),
+      number_of_matches_(-1),
+      active_match_ordinal_(-1),
+      final_update_(false) {}
+
   ~FindNotificationDetails() {}
 
   int request_id() const { return request_id_; }
@@ -39,11 +45,6 @@ class FindNotificationDetails {
   gfx::Rect selection_rect_;  // Where selection occurred (screen coordinate).
   int active_match_ordinal_;  // The ordinal of the currently selected match.
   bool final_update_;  // Whether this is the last Find Result update.
-
-  FindNotificationDetails() {}
-
-  DISALLOW_EVIL_CONSTRUCTORS(FindNotificationDetails);
 };
 
-#endif  // CHROME_BROWSER_FIND_NOTIFICATION_DETAILS_H__
-
+#endif  // CHROME_BROWSER_FIND_NOTIFICATION_DETAILS_H_