Window Delegate Improvements:

- Windows now must have a Delegate. Just construct the default WindowDelegate
if
you don't want to have to write one in testing.
- Windows now obtain their contents view by asking the delegate via
WindowDelegate::GetContentsView.
- Contents views no longer need to manually store a pointer to the Window that
contains them, WindowDelegate does this automatically via its window()
accessor.

Reviewer notes:
- review window_delegate.h first, then
- window.h/cc
- custom frame window.h/cc
- constrained_window_impl.h/cc
- then everything else (just updating all call sites)

B=1280060

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96 0039d316-1c4b-4281-b951-d872f2087c98

1 files changed, 2 insertions, 6 deletions

diff --git a/chrome/browser/first_run.cc b/chrome/browser/first_run.cc
index 950391b..51720ab 100644
--- a/chrome/browser/first_run.cc
+++ b/chrome/browser/first_run.cc
@@ -182,12 +182,8 @@ bool Upgrade::RelaunchChromeBrowser(const CommandLine& command_line) {
 }
 
 void OpenFirstRunDialog(Profile* profile) {
-  FirstRunView* first_run_view = new FirstRunView(profile);
-  ChromeViews::Window* first_run_dialog =
-      ChromeViews::Window::CreateChromeWindow(NULL, gfx::Rect(),
-                                              first_run_view, first_run_view);
-  first_run_dialog->Show();
-  first_run_view->set_dialog(first_run_dialog);
+  ChromeViews::Window::CreateChromeWindow(NULL, gfx::Rect(),
+                                          new FirstRunView(profile))->Show();
   // We must now run a message loop (will be terminated when the First Run UI
   // is closed) so that the window can receive messages and we block the
   // browser window from showing up. We pass the accelerator handler here so