diff options
author | msw@chromium.org <msw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-01-26 04:05:29 +0000 |
---|---|---|
committer | msw@chromium.org <msw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-01-26 04:05:29 +0000 |
commit | 2381ed2ed0e7560a29fe484d6c79103ca8eafa12 (patch) | |
tree | 59870ca2e3de1b1bece166dae2981a983ae65b54 /chrome/browser/first_run/first_run.cc | |
parent | 31d71b0e8b1b04c12e6ec654d9deca49f6303a6e (diff) | |
download | chromium_src-2381ed2ed0e7560a29fe484d6c79103ca8eafa12.zip chromium_src-2381ed2ed0e7560a29fe484d6c79103ca8eafa12.tar.gz chromium_src-2381ed2ed0e7560a29fe484d6c79103ca8eafa12.tar.bz2 |
Remove the first-run search engine dialog/ballot.
No changes to the Gtk and Mac first-run (reporting & default browser) dialog.
Tested optionally with GYP_DEFINES="branding=Chrome" and "--first-run --organic".
Chromium (all platforms): Shows the browser window directly (no dialog).
Chrome (Windows): Shows the browser window directly (no dialog).
Chrome (Linux and Mac): Shows the first-run (reporting & default browser) dialog before the browser window.
TODO(msw): Close crbug.com/111062 for removed test.
TODO(msw): Remove search engine icon/image resources (TemplateURL::logo_id_).
BUG=107005
TEST=No more standalone search engine selection dialog/ballot, Gtk and Mac first-run dialog works as before.
Review URL: http://codereview.chromium.org/9285002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119189 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/first_run/first_run.cc')
-rw-r--r-- | chrome/browser/first_run/first_run.cc | 22 |
1 files changed, 3 insertions, 19 deletions
diff --git a/chrome/browser/first_run/first_run.cc b/chrome/browser/first_run/first_run.cc index 27e9b34..5fa9b89 100644 --- a/chrome/browser/first_run/first_run.cc +++ b/chrome/browser/first_run/first_run.cc @@ -161,8 +161,6 @@ void AutoImportPlatformCommon( bool homepage_defined, int import_items, int dont_import_items, - bool search_engine_experiment, - bool randomize_search_engine_experiment, bool make_chrome_default) { FilePath local_state_path; PathService::Get(chrome::FILE_LOCAL_STATE, &local_state_path); @@ -226,13 +224,13 @@ void AutoImportPlatformCommon( content::RecordAction(UserMetricsAction("FirstRunDef_Accept")); - // Launch the search engine dialog only for certain builds, and only if the - // user has not already set preferences. + // Launch the first run dialog only for certain builds, and only if the user + // has not already set preferences. if (IsOrganicFirstRun() && !local_state_file_exists) { // The home page string may be set in the preferences, but the user should // initially use Chrome with the NTP as home page in organic builds. profile->GetPrefs()->SetBoolean(prefs::kHomePageIsNewTabPage, true); - ShowFirstRunDialog(profile, randomize_search_engine_experiment); + ShowFirstRunDialog(profile); } if (make_chrome_default) @@ -324,10 +322,6 @@ bool SetPersonalDataManagerFirstRunPref() { return true; } -bool ShouldShowSearchEngineSelector(const TemplateURLService* model) { - return model && !model->is_default_search_managed(); -} - } // namespace first_run // FirstRun ------------------------------------------------------------------- @@ -337,8 +331,6 @@ FirstRun::MasterPrefs::MasterPrefs() homepage_defined(false), do_import_items(0), dont_import_items(0), - run_search_engine_experiment(false), - randomize_search_engine_experiment(false), make_chrome_default(false) { } @@ -425,14 +417,6 @@ bool FirstRun::ProcessMasterPreferences(const FilePath& user_data_dir, } } - // Check to see if search engine logos should be randomized. - if (prefs.GetBool( - installer::master_preferences:: - kSearchEngineExperimentRandomizePref, - &value) && value) { - out_prefs->randomize_search_engine_experiment = true; - } - // If we're suppressing the first-run bubble, set that preference now. // Otherwise, wait until the user has completed first run to set it, so the // user is guaranteed to see the bubble iff he or she has completed the first |