diff options
| author | finnur@chromium.org <finnur@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-01-20 12:43:40 +0000 |
|---|---|---|
| committer | finnur@chromium.org <finnur@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-01-20 12:43:40 +0000 |
| commit | cd4d490ae5d751841bb2beac3a81bfb982aad562 (patch) | |
| tree | 39f9e8c354ce8e163dc70c7fd4fb444378197b61 /chrome/browser/first_run | |
| parent | 44d66c7540bac2e8e60d2c4aa32781b0d505a468 (diff) | |
| download | chromium_src-cd4d490ae5d751841bb2beac3a81bfb982aad562.zip chromium_src-cd4d490ae5d751841bb2beac3a81bfb982aad562.tar.gz chromium_src-cd4d490ae5d751841bb2beac3a81bfb982aad562.tar.bz2 | |
Restricting test to run on Windows only, since test harness on Mac and Linux times out if the browser exits too early.
BUG=45115
TEST=None
Review URL: https://chromiumcodereview.appspot.com/9233007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118436 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/first_run')
| -rw-r--r-- | chrome/browser/first_run/try_chrome_dialog_view_browsertest.cc | 11 |
1 files changed, 11 insertions, 0 deletions
diff --git a/chrome/browser/first_run/try_chrome_dialog_view_browsertest.cc b/chrome/browser/first_run/try_chrome_dialog_view_browsertest.cc index a9531521..9b380b4 100644 --- a/chrome/browser/first_run/try_chrome_dialog_view_browsertest.cc +++ b/chrome/browser/first_run/try_chrome_dialog_view_browsertest.cc @@ -6,6 +6,15 @@ #include "chrome/common/chrome_switches.h" #include "chrome/test/base/in_process_browser_test.h" +// Unfortunately, this needs to be Windows only for now. Even though this test +// is meant to exercise code that is for Windows only, it is a good general +// canary in the coal mine for problems related to early shutdown (aborted +// startup). Sadly, it times out on platforms other than Windows, so I can't +// enable it for those platforms at the moment. I hope one day our test harness +// will be improved to support this so we can get coverage on other platforms. +// See http://crbug.com/45115 for details. +#if defined(OS_WIN) + // By passing kTryChromeAgain with a magic value > 10000 we cause Chrome // to exit fairly early. // Quickly exiting Chrome (regardless of this particular flag -- it @@ -22,3 +31,5 @@ protected: } }; IN_PROC_BROWSER_TEST_F(TryChromeDialogBrowserTest, ToastCrasher) {} + +#endif // defined(OS_WIN) |