diff options
author | marja@chromium.org <marja@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-02-15 15:44:31 +0000 |
---|---|---|
committer | marja@chromium.org <marja@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-02-15 15:44:31 +0000 |
commit | 6aae28d4394aa30785f31530e20c6a259ef39e01 (patch) | |
tree | ae25dec3f9bb36b72ba0297e5e108a786ae2c6ea /chrome/browser/first_run | |
parent | f4c912ad64cf85099fee7b8c94603eb2bb061524 (diff) | |
download | chromium_src-6aae28d4394aa30785f31530e20c6a259ef39e01.zip chromium_src-6aae28d4394aa30785f31530e20c6a259ef39e01.tar.gz chromium_src-6aae28d4394aa30785f31530e20c6a259ef39e01.tar.bz2 |
Revert 122079 - Revert 122077 - Revert 122065 - Fix attempt for the double-SessionRestoreImpl problem.
The problem is that BrowserInit::ProcessCommandLineAlreadyRunning gets called too
early, before launching the first profile during normal startup.
BUG=111238
TEST=NONE
Review URL: http://codereview.chromium.org/9365049
TBR=marja@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9402007
TBR=marja@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9409001
TBR=marja@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9403015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@122088 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/first_run')
-rw-r--r-- | chrome/browser/first_run/try_chrome_dialog_view.cc | 10 |
1 files changed, 4 insertions, 6 deletions
diff --git a/chrome/browser/first_run/try_chrome_dialog_view.cc b/chrome/browser/first_run/try_chrome_dialog_view.cc index 71135a7..f1da73d 100644 --- a/chrome/browser/first_run/try_chrome_dialog_view.cc +++ b/chrome/browser/first_run/try_chrome_dialog_view.cc @@ -227,14 +227,12 @@ TryChromeDialogView::Result TryChromeDialogView::ShowModal( SetToastRegion(popup_->GetNativeView(), preferred.width(), preferred.height()); - // Time to show the window in a modal loop. The ProcessSingleton should - // already be locked and it will not process WM_COPYDATA requests. Change the - // window to bring to foreground if a request arrives. - CHECK(process_singleton->locked()); - process_singleton->SetForegroundWindow(popup_->GetNativeView()); + // Time to show the window in a modal loop. We don't want this chrome + // instance trying to serve WM_COPYDATA requests, as we'll surely crash. + process_singleton->Lock(popup_->GetNativeView()); popup_->Show(); MessageLoop::current()->Run(); - process_singleton->SetForegroundWindow(NULL); + process_singleton->Unlock(); return result_; } |