diff options
author | joi@chromium.org <joi@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-03-12 20:15:34 +0000 |
---|---|---|
committer | joi@chromium.org <joi@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-03-12 20:15:34 +0000 |
commit | c025738684582542a2a5cd5ffa2fbdd5ab28f6ce (patch) | |
tree | a5e25311fab5628c430660786a77bb4b2b7456db /chrome/browser/geolocation | |
parent | 8c0eb70b0f944127475e420765286ac082645dd4 (diff) | |
download | chromium_src-c025738684582542a2a5cd5ffa2fbdd5ab28f6ce.zip chromium_src-c025738684582542a2a5cd5ffa2fbdd5ab28f6ce.tar.gz chromium_src-c025738684582542a2a5cd5ffa2fbdd5ab28f6ce.tar.bz2 |
Introduce abstractions to allow embedders to test RenderViewHost
without knowing about content's internals.
From the embedders' point of view, this is done by splitting the
"tester" interface away from the RenderViewHost interface, rather than
extending the parallel interface/implementation hierarchy; see
comments on TestRenderViewHost for the rationale.
TBR=ben@chromium.org
BUG=98716
Review URL: https://chromiumcodereview.appspot.com/9645003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126200 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/geolocation')
-rw-r--r-- | chrome/browser/geolocation/chrome_geolocation_permission_context_unittest.cc | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/chrome/browser/geolocation/chrome_geolocation_permission_context_unittest.cc b/chrome/browser/geolocation/chrome_geolocation_permission_context_unittest.cc index f4bad47..c1ca818 100644 --- a/chrome/browser/geolocation/chrome_geolocation_permission_context_unittest.cc +++ b/chrome/browser/geolocation/chrome_geolocation_permission_context_unittest.cc @@ -26,9 +26,11 @@ #include "content/public/browser/notification_service.h" #include "content/test/mock_geolocation.h" #include "content/test/test_browser_thread.h" +#include "content/test/test_renderer_host.h" #include "testing/gtest/include/gtest/gtest.h" using content::BrowserThread; +using content::RenderViewHostTester; using content::WebContents; // ClosedDelegateTracker ------------------------------------------------------ @@ -207,7 +209,7 @@ void GeolocationPermissionContextTests::AddNewTab(const GURL& url) { WebContents::Create(profile(), NULL, MSG_ROUTING_NONE, NULL, NULL); new_tab->GetController().LoadURL( url, content::Referrer(), content::PAGE_TRANSITION_TYPED, std::string()); - static_cast<content::TestRenderViewHost*>(new_tab->GetRenderViewHost())-> + RenderViewHostTester::For(new_tab->GetRenderViewHost())-> SendNavigate(extra_tabs_.size() + 1, url); extra_tabs_.push_back(new TabContentsWrapper(new_tab)); } |