- Make user script loading asynchronous on the file thread.

- Automatically reload scripts when the directory changes.
- Add a unit test for the GreasemonkeyMaster.
Review URL: http://codereview.chromium.org/7472

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4069 0039d316-1c4b-4281-b951-d872f2087c98

1 files changed, 118 insertions, 0 deletions

diff --git a/chrome/browser/greasemonkey_master_unittest.cc b/chrome/browser/greasemonkey_master_unittest.cc
new file mode 100644
index 0000000..b3ce12f
--- /dev/null
+++ b/chrome/browser/greasemonkey_master_unittest.cc
@@ -0,0 +1,118 @@
+// Copyright (c) 2008 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/greasemonkey_master.h"
+
+#include <fstream>
+
+#include "base/file_path.h"
+#include "base/file_util.h"
+#include "base/message_loop.h"
+#include "base/path_service.h"
+#include "base/string_util.h"
+#include "chrome/common/notification_service.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+// Test bringing up a master on a specific directory, putting a script in there, etc.
+
+class GreasemonkeyMasterTest : public testing::Test,
+                               public NotificationObserver {
+ public:
+  GreasemonkeyMasterTest() : shared_memory_(NULL) {}
+
+  virtual void SetUp() {
+    // Name a subdirectory of the temp directory.
+    std::wstring path_str;
+    ASSERT_TRUE(PathService::Get(base::DIR_TEMP, &path_str));
+    script_dir_ = FilePath(path_str).Append(
+        FILE_PATH_LITERAL("GreasemonkeyTest"));
+
+    // Create a fresh, empty copy of this directory.
+    file_util::Delete(script_dir_.value(), true);
+    file_util::CreateDirectory(script_dir_.value());
+
+    // Register for all user script notifications.
+    NotificationService::current()->AddObserver(this,
+        NOTIFY_NEW_USER_SCRIPTS,
+        NotificationService::AllSources());
+  }
+
+  virtual void TearDown() {
+    NotificationService::current()->RemoveObserver(this,
+        NOTIFY_NEW_USER_SCRIPTS,
+        NotificationService::AllSources());
+
+    // Clean up test directory.
+    ASSERT_TRUE(file_util::Delete(script_dir_.value(), true));
+    ASSERT_FALSE(file_util::PathExists(script_dir_.value()));
+  }
+
+  virtual void Observe(NotificationType type,
+                       const NotificationSource& source,
+                       const NotificationDetails& details) {
+    DCHECK(type == NOTIFY_NEW_USER_SCRIPTS);
+
+    shared_memory_ = Details<SharedMemory>(details).ptr();
+    if (MessageLoop::current() == &message_loop_)
+      MessageLoop::current()->Quit();
+  }
+
+  // MessageLoop used in tests.
+  MessageLoop message_loop_;
+
+  // Directory containing user scripts.
+  FilePath script_dir_;
+
+  // Updated to the script shared memory when we get notified.
+  SharedMemory* shared_memory_;
+};
+
+// Test that we *don't* get spurious notifications.
+TEST_F(GreasemonkeyMasterTest, NoScripts) {
+  // Set shared_memory_ to something non-NULL, so we can check it became NULL.
+  shared_memory_ = reinterpret_cast<SharedMemory*>(1);
+
+  scoped_refptr<GreasemonkeyMaster> master(
+      new GreasemonkeyMaster(MessageLoop::current(), script_dir_));
+  message_loop_.PostTask(FROM_HERE, new MessageLoop::QuitTask);
+  message_loop_.Run();
+
+  // There were no scripts in the script dir, so we shouldn't have gotten
+  // a notification.
+  ASSERT_EQ(NULL, shared_memory_);
+}
+
+// Test that we get notified about new scripts after they're added.
+TEST_F(GreasemonkeyMasterTest, NewScripts) {
+  scoped_refptr<GreasemonkeyMaster> master(
+      new GreasemonkeyMaster(MessageLoop::current(), script_dir_));
+
+  FilePath path = script_dir_.Append(FILE_PATH_LITERAL("script.user.js"));
+
+  std::ofstream file;
+  file.open(WideToUTF8(path.value()).c_str());
+  file << "some content";
+  file.close();
+
+  message_loop_.Run();
+
+  ASSERT_TRUE(shared_memory_ != NULL);
+}
+
+// Test that we get notified about scripts if they're already in the test dir.
+TEST_F(GreasemonkeyMasterTest, ExistingScripts) {
+  FilePath path = script_dir_.Append(FILE_PATH_LITERAL("script.user.js"));
+  std::ofstream file;
+  file.open(WideToUTF8(path.value()).c_str());
+  file << "some content";
+  file.close();
+
+  scoped_refptr<GreasemonkeyMaster> master(
+      new GreasemonkeyMaster(MessageLoop::current(), script_dir_));
+
+  message_loop_.PostTask(FROM_HERE, new MessageLoop::QuitTask);
+  message_loop_.Run();
+
+  ASSERT_TRUE(shared_memory_ != NULL);
+}
\ No newline at end of file