diff options
author | erg@google.com <erg@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-04-28 19:32:15 +0000 |
---|---|---|
committer | erg@google.com <erg@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-04-28 19:32:15 +0000 |
commit | ef49de68beef6d5adf699518f8ef86f47b9f8b33 (patch) | |
tree | d325591020879e84a6bdea2433f1893a78ca75da /chrome/browser/gtk/bookmark_editor_gtk.cc | |
parent | b938c4cd5adac79efc4453ccf1a53f9e70c29293 (diff) | |
download | chromium_src-ef49de68beef6d5adf699518f8ef86f47b9f8b33.zip chromium_src-ef49de68beef6d5adf699518f8ef86f47b9f8b33.tar.gz chromium_src-ef49de68beef6d5adf699518f8ef86f47b9f8b33.tar.bz2 |
Create a bookmark editor dialog interface and implement a GTK version.
The GTK version is currently limited to only editing the name/url of the
bookmark; I'm submitting this since it's getting big and I want a design
review.
Review URL: http://codereview.chromium.org/99131
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14763 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/gtk/bookmark_editor_gtk.cc')
-rw-r--r-- | chrome/browser/gtk/bookmark_editor_gtk.cc | 308 |
1 files changed, 308 insertions, 0 deletions
diff --git a/chrome/browser/gtk/bookmark_editor_gtk.cc b/chrome/browser/gtk/bookmark_editor_gtk.cc new file mode 100644 index 0000000..dae1b8f --- /dev/null +++ b/chrome/browser/gtk/bookmark_editor_gtk.cc @@ -0,0 +1,308 @@ +// Copyright (c) 2009 The Chromium Authors. All rights reserved. +// Use of this source code is governed by a BSD-style license that can be +// found in the LICENSE file. + +#include "chrome/browser/gtk/bookmark_editor_gtk.h" + +#include <gtk/gtk.h> + +#include "base/basictypes.h" +#include "base/gfx/gtk_util.h" +#include "base/logging.h" +#include "base/string_util.h" +#include "chrome/browser/history/history.h" +#include "chrome/browser/profile.h" +#include "chrome/browser/net/url_fixer_upper.h" +#include "chrome/common/l10n_util.h" +#include "googleurl/src/gurl.h" +#include "grit/chromium_strings.h" +#include "grit/generated_resources.h" +#include "grit/locale_settings.h" + +namespace { + +// Background color of text field when URL is invalid. +const GdkColor kErrorColor = GDK_COLOR_RGB(0xFF, 0xBC, 0xBC); + +// Preferred width of the tree. +static const int kTreeWidth = 300; + +} // namespace + +// static +void BookmarkEditor::Show(gfx::NativeWindow parent_hwnd, + Profile* profile, + BookmarkNode* parent, + BookmarkNode* node, + Configuration configuration, + Handler* handler) { + DCHECK(profile); + BookmarkEditorGtk* editor = + new BookmarkEditorGtk(parent_hwnd, profile, parent, node, configuration, + handler); + editor->Show(); +} + +BookmarkEditorGtk::BookmarkEditorGtk( + GtkWindow* window, + Profile* profile, + BookmarkNode* parent, + BookmarkNode* node, + BookmarkEditor::Configuration configuration, + BookmarkEditor::Handler* handler) + : profile_(profile), + dialog_(NULL), + parent_(parent), + node_(node), + running_menu_for_root_(false), + show_tree_(configuration == SHOW_TREE), + handler_(handler) { + DCHECK(profile); + Init(window); +} + +BookmarkEditorGtk::~BookmarkEditorGtk() { + // The tree model is deleted before the view. Reset the model otherwise the + // tree will reference a deleted model. + + // TODO(erg): Enable this when we have a |tree_view_|. + // if (tree_view_) + // tree_view_->SetModel(NULL); + bb_model_->RemoveObserver(this); +} + +void BookmarkEditorGtk::Init(GtkWindow* parent_window) { + bb_model_ = profile_->GetBookmarkModel(); + DCHECK(bb_model_); + bb_model_->AddObserver(this); + + dialog_ = gtk_dialog_new_with_buttons( + l10n_util::GetStringUTF8(IDS_BOOMARK_EDITOR_TITLE).c_str(), + parent_window, + GTK_DIALOG_MODAL, + NULL); + + // TODO(erg): Add "New Folder" button here and insert at correct place; to + // the extreme left of the dialog. + close_button_ = gtk_dialog_add_button(GTK_DIALOG(dialog_), + GTK_STOCK_CANCEL, + GTK_RESPONSE_REJECT); + ok_button_ = gtk_dialog_add_button(GTK_DIALOG(dialog_), + GTK_STOCK_OK, GTK_RESPONSE_ACCEPT); + gtk_dialog_set_default_response(GTK_DIALOG(dialog_), GTK_RESPONSE_ACCEPT); + + // The GTK dialog content area layout (overview) + // + // +- GtkVBox |content_area| --------------------------------------+ + // |+- GtkTable |table| ------------------------------------------+| + // ||+- GtkLabel ------+ +- GtkEntry |name_entry_| --------------+|| + // ||| | | ||| + // ||+-----------------+ +---------------------------------------+|| + // ||+- GtkLabel ------+ +- GtkEntry |url_entry_| ---------------+|| + // ||| | | ||| + // ||+-----------------+ +---------------------------------------+|| + // |+-------------------------------------------------------------+| + // +---------------------------------------------------------------+ + GtkWidget* content_area = GTK_DIALOG(dialog_)->vbox; + gtk_container_set_border_width(GTK_CONTAINER(content_area), 12); + GtkWidget* table = gtk_table_new(2, 2, FALSE); + + GtkWidget* label = gtk_label_new( + l10n_util::GetStringUTF8(IDS_BOOMARK_EDITOR_NAME_LABEL).c_str()); + gtk_table_attach(GTK_TABLE(table), GTK_WIDGET(label), + 0, 1, 0, 1, + (GtkAttachOptions)(GTK_SHRINK), + (GtkAttachOptions)(GTK_SHRINK), + 12, 0); + name_entry_ = gtk_entry_new(); + gtk_entry_set_text(GTK_ENTRY(name_entry_), + node_ ? WideToUTF8(node_->GetTitle()).c_str() : ""); + g_signal_connect(G_OBJECT(name_entry_), "changed", + G_CALLBACK(OnEntryChanged), this); + g_object_set(G_OBJECT(name_entry_), "activates-default", TRUE, NULL); + gtk_table_attach(GTK_TABLE(table), GTK_WIDGET(name_entry_), + 1, 2, 0, 1, + (GtkAttachOptions)(GTK_EXPAND | GTK_FILL), + (GtkAttachOptions)(GTK_FILL), + 0, 0); + + label = gtk_label_new( + l10n_util::GetStringUTF8(IDS_BOOMARK_EDITOR_URL_LABEL).c_str()); + gtk_table_attach(GTK_TABLE(table), GTK_WIDGET(label), + 0, 1, 1, 2, + (GtkAttachOptions)(GTK_SHRINK), + (GtkAttachOptions)(GTK_SHRINK), + 12, 0); + url_entry_ = gtk_entry_new(); + gtk_entry_set_text(GTK_ENTRY(url_entry_), + node_ ? node_->GetURL().spec().c_str() : ""); + g_signal_connect(G_OBJECT(url_entry_), "changed", + G_CALLBACK(OnEntryChanged), this); + g_object_set(G_OBJECT(url_entry_), "activates-default", TRUE, NULL); + gtk_table_attach(GTK_TABLE(table), GTK_WIDGET(url_entry_), + 1, 2, 1, 2, + (GtkAttachOptions)(GTK_EXPAND | GTK_FILL), + (GtkAttachOptions)(GTK_FILL), + 0, 0); + + gtk_box_pack_start(GTK_BOX(content_area), table, FALSE, FALSE, 0); + + // TODO(erg): Port the windows bookmark tree model and enable this tree view. + // + // folder_tree_ = gtk_tree_view_new(); + // gtk_tree_view_set_headers_visible(GTK_TREE_VIEW(folder_tree_), TRUE); + // gtk_widget_set_size_request(folder_tree_, kTreeWidth, -1); + // gtk_widget_show(folder_tree_); + // gtk_box_pack_start(GTK_BOX(content_area), folder_tree_, FALSE, FALSE, 0); + + g_signal_connect(dialog_, "response", + G_CALLBACK(OnResponse), this); + g_signal_connect(dialog_, "delete-event", + G_CALLBACK(OnWindowDeleteEvent), this); + g_signal_connect(dialog_, "destroy", + G_CALLBACK(OnWindowDestroy), this); +} + +void BookmarkEditorGtk::Show() { + // Manually call our OnEntryChanged handler to set the initial state. + OnEntryChanged(NULL, this); + + gtk_widget_show_all(dialog_); +} + +void BookmarkEditorGtk::Close() { + // Under the model that we've inherited from Windows, dialogs can receive + // more than one Close() call inside the current message loop event. + if (dialog_) { + gtk_widget_destroy(dialog_); + dialog_ = NULL; + } +} + +void BookmarkEditorGtk::BookmarkNodeMoved(BookmarkModel* model, + BookmarkNode* old_parent, + int old_index, + BookmarkNode* new_parent, + int new_index) { + Reset(); +} + +void BookmarkEditorGtk::BookmarkNodeAdded(BookmarkModel* model, + BookmarkNode* parent, + int index) { + Reset(); +} + +void BookmarkEditorGtk::BookmarkNodeRemoved(BookmarkModel* model, + BookmarkNode* parent, + int index, + BookmarkNode* node) { + if ((node_ && node_->HasAncestor(node)) || + (parent_ && parent_->HasAncestor(node))) { + // The node, or its parent was removed. Close the dialog. + Close(); + } else { + Reset(); + } +} + +void BookmarkEditorGtk::BookmarkNodeChildrenReordered(BookmarkModel* model, + BookmarkNode* node) { + Reset(); +} + +void BookmarkEditorGtk::Reset() { + // TODO(erg): The windows implementation tries to be smart. For now, just + // close the window. + Close(); +} + +GURL BookmarkEditorGtk::GetInputURL() const { + std::wstring input = URLFixerUpper::FixupURL( + UTF8ToWide(gtk_entry_get_text(GTK_ENTRY(url_entry_))), L""); + return GURL(WideToUTF8(input)); +} + +std::wstring BookmarkEditorGtk::GetInputTitle() const { + return UTF8ToWide(gtk_entry_get_text(GTK_ENTRY(name_entry_))); +} + +void BookmarkEditorGtk::ApplyEdits() { + // TODO(erg): This is massively simplified because I haven't added a + // GtkTreeView to this class yet. Then, this will have to be a copy of + // BookmarkEditorView::ApplyEdits(). + + // We're going to apply edits to the bookmark bar model, which will call us + // back. Normally when a structural edit occurs we reset the tree model. + // We don't want to do that here, so we remove ourselves as an observer. + bb_model_->RemoveObserver(this); + + GURL new_url(GetInputURL()); + std::wstring new_title(GetInputTitle()); + + BookmarkNode* old_parent = node_ ? node_->GetParent() : NULL; + const int old_index = old_parent ? old_parent->IndexOfChild(node_) : -1; + + if (!node_) { + BookmarkNode* node = + bb_model_->AddURL(parent_, parent_->GetChildCount(), new_title, + new_url); + if (handler_.get()) + handler_->NodeCreated(node); + return; + } + // If we're not showing the tree we only need to modify the node. + if (old_index == -1) { + NOTREACHED(); + return; + } + if (new_url != node_->GetURL()) { + bb_model_->AddURLWithCreationTime(old_parent, old_index, new_title, + new_url, node_->date_added()); + bb_model_->Remove(old_parent, old_index + 1); + } else { + bb_model_->SetTitle(node_, new_title); + } +} + +// static +void BookmarkEditorGtk::OnResponse(GtkDialog* dialog, int response_id, + BookmarkEditorGtk* window) { + if (response_id == GTK_RESPONSE_ACCEPT) { + window->ApplyEdits(); + } + + window->Close(); +} + +// static +gboolean BookmarkEditorGtk::OnWindowDeleteEvent( + GtkWidget* widget, + GdkEvent* event, + BookmarkEditorGtk* dialog) { + dialog->Close(); + + // Return true to prevent the gtk dialog from being destroyed. Close will + // destroy it for us and the default gtk_dialog_delete_event_handler() will + // force the destruction without us being able to stop it. + return TRUE; +} + +// static +void BookmarkEditorGtk::OnWindowDestroy(GtkWidget* widget, + BookmarkEditorGtk* dialog) { + MessageLoop::current()->DeleteSoon(FROM_HERE, dialog); +} + +// static +void BookmarkEditorGtk::OnEntryChanged(GtkEditable* entry, + BookmarkEditorGtk* dialog) { + const GURL url(dialog->GetInputURL()); + if (!url.is_valid()) { + gtk_widget_modify_base(dialog->url_entry_, GTK_STATE_NORMAL, &kErrorColor); + gtk_widget_set_sensitive(GTK_WIDGET(dialog->ok_button_), false); + } else { + gtk_widget_modify_base(dialog->url_entry_, GTK_STATE_NORMAL, NULL); + gtk_widget_set_sensitive(GTK_WIDGET(dialog->ok_button_), true); + } +} |