summaryrefslogtreecommitdiffstats
path: root/chrome/browser/gtk/bookmark_utils_gtk_unittest.cc
diff options
context:
space:
mode:
authorthestig@chromium.org <thestig@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2010-05-07 19:36:15 +0000
committerthestig@chromium.org <thestig@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2010-05-07 19:36:15 +0000
commit5c311356f75f014502b63f1afa79c5452a0cfa59 (patch)
tree8d366c605865ed25fecdff19f23418819e01e0a3 /chrome/browser/gtk/bookmark_utils_gtk_unittest.cc
parent6eab9e655b841f03da3de2640e4d85e5d5be425a (diff)
downloadchromium_src-5c311356f75f014502b63f1afa79c5452a0cfa59.zip
chromium_src-5c311356f75f014502b63f1afa79c5452a0cfa59.tar.gz
chromium_src-5c311356f75f014502b63f1afa79c5452a0cfa59.tar.bz2
gtk: Fix bookmark_utils::GetNodesFromSelection to not crash on invalid data.
BUG=43347 TEST=included Review URL: http://codereview.chromium.org/2048002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46730 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/gtk/bookmark_utils_gtk_unittest.cc')
-rw-r--r--chrome/browser/gtk/bookmark_utils_gtk_unittest.cc38
1 files changed, 38 insertions, 0 deletions
diff --git a/chrome/browser/gtk/bookmark_utils_gtk_unittest.cc b/chrome/browser/gtk/bookmark_utils_gtk_unittest.cc
new file mode 100644
index 0000000..be22a10
--- /dev/null
+++ b/chrome/browser/gtk/bookmark_utils_gtk_unittest.cc
@@ -0,0 +1,38 @@
+// Copyright (c) 2010 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "app/gtk_dnd_util.h"
+#include "chrome/browser/gtk/bookmark_utils_gtk.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+TEST(BookmarkUtilsGtkTest, GetNodesFromSelectionInvalid) {
+ std::vector<const BookmarkNode*> nodes;
+ nodes = bookmark_utils::GetNodesFromSelection(NULL, NULL, 0, NULL, NULL,
+ NULL);
+ EXPECT_EQ(0u, nodes.size());
+
+ GtkSelectionData data;
+ data.data = NULL;
+ data.length = 0;
+ nodes = bookmark_utils::GetNodesFromSelection(NULL, &data, 0, NULL, NULL,
+ NULL);
+ EXPECT_EQ(0u, nodes.size());
+
+ nodes = bookmark_utils::GetNodesFromSelection(NULL, NULL,
+ gtk_dnd_util::CHROME_BOOKMARK_ITEM, NULL, NULL, NULL);
+ EXPECT_EQ(0u, nodes.size());
+
+ data.data = NULL;
+ data.length = 0;
+ nodes = bookmark_utils::GetNodesFromSelection(NULL, &data,
+ gtk_dnd_util::CHROME_BOOKMARK_ITEM, NULL, NULL, NULL);
+ EXPECT_EQ(0u, nodes.size());
+
+ guchar test_data[] = "";
+ data.data = test_data;
+ data.length = 0;
+ nodes = bookmark_utils::GetNodesFromSelection(NULL, &data,
+ gtk_dnd_util::CHROME_BOOKMARK_ITEM, NULL, NULL, NULL);
+ EXPECT_EQ(0u, nodes.size());
+}