diff options
| author | estade@chromium.org <estade@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-07-10 18:23:58 +0000 |
|---|---|---|
| committer | estade@chromium.org <estade@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-07-10 18:23:58 +0000 |
| commit | 9f040e43fec71f77dd9c201aa5397e314de4c07a (patch) | |
| tree | 951f4bde2e7f6dc1d9c3a1dc1923890aa1c80b5d /chrome/browser/gtk/browser_toolbar_gtk.cc | |
| parent | 0e161112cc06b7d77d8c9b73b334b209d79e12d1 (diff) | |
| download | chromium_src-9f040e43fec71f77dd9c201aa5397e314de4c07a.zip chromium_src-9f040e43fec71f77dd9c201aa5397e314de4c07a.tar.gz chromium_src-9f040e43fec71f77dd9c201aa5397e314de4c07a.tar.bz2 | |
A little bit of bookmark bar cleanup, a little bit of padding improvement.
The spacing between the toolbar buttons now matches windows pixel for pixel (tested empirically).
The bookmark bar item spacing is now a little better, but we need some hackery to improve it to the state of windows (we need to annex about 5 pixels from the toolbar when the bookmark bar is open).
The code for packing bookmark bar buttons is now all in one place.
Functional change: There will be no other bookmarks button until the model is loaded. If you care I can fix this, it just doesn't seem like a very important matter since it's unusable anyway when the model isn't loaded.o
I also removed a log warning from chrome_dll_main because with this change it started spamming a lot. We're already living with this warning, and have a bug filed for it (they fixed the root problem in newer versions of gtk so I think this bug will just never get resolved), so I don't think this is a big deal.
BUG=15870
TEST=things look marginally better, theming still works properly
Review URL: http://codereview.chromium.org/155342
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20389 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/gtk/browser_toolbar_gtk.cc')
| -rw-r--r-- | chrome/browser/gtk/browser_toolbar_gtk.cc | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/chrome/browser/gtk/browser_toolbar_gtk.cc b/chrome/browser/gtk/browser_toolbar_gtk.cc index e3ce104..673e4bf 100644 --- a/chrome/browser/gtk/browser_toolbar_gtk.cc +++ b/chrome/browser/gtk/browser_toolbar_gtk.cc @@ -45,7 +45,7 @@ namespace { const int kToolbarHeight = 37; // Interior spacing between toolbar widgets. -const int kToolbarWidgetSpacing = 6; +const int kToolbarWidgetSpacing = 4; // The amount of space between the bottom of the star and the top of the // Omnibox results popup window. We want a two pixel space between the bottom |