Linux toolbar cleanups.

1) Set a consistent padding between toolbar buttons by grouping controls
that have different paddings into hboxes.  E.g., back/forward are in a
grouped hbox and the menu buttons are in an hbox.

2) Hook the home button up to the user pref.

3) Change how we show the various widgets so home button only shows up
when the pref is enabled.

Review URL: http://codereview.chromium.org/118195


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17642 0039d316-1c4b-4281-b951-d872f2087c98

1 files changed, 5 insertions, 6 deletions

diff --git a/chrome/browser/gtk/browser_toolbar_gtk.h b/chrome/browser/gtk/browser_toolbar_gtk.h
index 8f7542d..2afb4ab 100644
--- a/chrome/browser/gtk/browser_toolbar_gtk.h
+++ b/chrome/browser/gtk/browser_toolbar_gtk.h
@@ -84,12 +84,14 @@ class BrowserToolbarGtk : public CommandUpdater::CommandObserver,
                                        int active_id,
                                        int highlight_id,
                                        int depressed_id,
-                                       const std::string& localized_tooltip,
-                                       int spacing);
+                                       const std::string& localized_tooltip);
 
+  // Create the star button given the tooltip.  Returns the widget created.
   ToolbarStarToggleGtk* BuildStarButton(const std::string& localized_tooltip);
 
-  void BuildToolbarMenuButton(
+  // Create a menu for the toolbar given the icon id and tooltip.  Returns the
+  // widget created.
+  GtkWidget* BuildToolbarMenuButton(
       int icon_id,
       const std::string& localized_tooltip,
       OwnedWidgetGtk* owner);
@@ -111,9 +113,6 @@ class BrowserToolbarGtk : public CommandUpdater::CommandObserver,
                                          GdkEventButton* event,
                                          BrowserToolbarGtk* toolbar);
 
-  // Construct the Home button.
-  CustomDrawButton* MakeHomeButton();
-
   // Initialize the background NineBox.
   void InitNineBox();