Linux: Make InfoBubble use an override-redirect (popup) window.

This makes it work correctly in ion3 and other window managers that don't expect clients to try to move top-level windows themselves.

This implementation grabs the pointer and keyboard.  By doing this and using an override-redirect window, we should be able to avoid worrying about interactions with different window managers.  The only downside (alluded to in the previous code) is that window manager keybindings don't make it through until the user dismisses the bubble by clicking outside of it or hitting Enter or Escape.  I don't think this will be a problem; it's no different from what happens when you open a context menu in an app.

BUG=20523
TEST=tested first-run and bookmark bubbles in Metacity, ion3, Fluxbox, KDE4, and the WM that I'm working on

Review URL: http://codereview.chromium.org/198016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27578 0039d316-1c4b-4281-b951-d872f2087c98

1 files changed, 1 insertions, 8 deletions

diff --git a/chrome/browser/gtk/browser_window_gtk.cc b/chrome/browser/gtk/browser_window_gtk.cc
index b617829..f6e85f1 100644
--- a/chrome/browser/gtk/browser_window_gtk.cc
+++ b/chrome/browser/gtk/browser_window_gtk.cc
@@ -1230,14 +1230,7 @@ void BrowserWindowGtk::ActiveWindowChanged(GdkWindow* active_window) {
   if (!window_)
     return;
 
-  // If we lose focus to an info bubble, we don't want to seem inactive.
-  // However we can only control this when we are painting a custom
-  // frame. So if we lose focus BUT it's to one of our info bubbles AND we
-  // are painting a custom frame, then paint as if we are active.
-  const GtkWindow* info_bubble_toplevel =
-      InfoBubbleGtk::GetToplevelForInfoBubble(active_window);
-  bool is_active = (GTK_WIDGET(window_)->window == active_window ||
-                    (window_ == info_bubble_toplevel && UseCustomFrame()));
+  bool is_active = (GTK_WIDGET(window_)->window == active_window);
   bool changed = (is_active != is_active_);
 
   if (is_active && changed) {