diff options
author | thakis@chromium.org <thakis@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-08-27 21:13:42 +0000 |
---|---|---|
committer | thakis@chromium.org <thakis@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-08-27 21:13:42 +0000 |
commit | 848364347bff182dbf8a0c2f22ed3ed5d65bca4e (patch) | |
tree | e79de6d570b32c486996e580d49c1a63209338b0 /chrome/browser/gtk/download_item_gtk.h | |
parent | 80b7f1a8bfd97d4d8b268329932efba1d4f49567 (diff) | |
download | chromium_src-848364347bff182dbf8a0c2f22ed3ed5d65bca4e.zip chromium_src-848364347bff182dbf8a0c2f22ed3ed5d65bca4e.tar.gz chromium_src-848364347bff182dbf8a0c2f22ed3ed5d65bca4e.tar.bz2 |
Remove completed downloads from shelf when the shelf closes.
BUG=15712
TEST=Download a few things, close shelf, download something else, note initial few things are no longer on the shelf.
Special cases:
* Dangerous downloads still awaiting affirmation should never be removed, no matter if they are completed or not.
* Cancelled downloads should be removed.
* In-progress downloads should not be removed.
Review URL: http://codereview.chromium.org/173186
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24663 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/gtk/download_item_gtk.h')
-rw-r--r-- | chrome/browser/gtk/download_item_gtk.h | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/chrome/browser/gtk/download_item_gtk.h b/chrome/browser/gtk/download_item_gtk.h index 4557695..c490c94 100644 --- a/chrome/browser/gtk/download_item_gtk.h +++ b/chrome/browser/gtk/download_item_gtk.h @@ -53,11 +53,12 @@ class DownloadItemGtk : public DownloadItem::Observer, // ownership of |icon_bitmap|. void OnLoadIconComplete(IconManager::Handle handle, SkBitmap* icon_bitmap); + // Returns the DownloadItem model object belonging to this item. + DownloadItem* get_download(); + private: friend class DownloadShelfContextMenuGtk; - DownloadItem* get_download(); - // Returns true IFF the download is dangerous and unconfirmed. bool IsDangerous(); @@ -203,6 +204,7 @@ class DownloadItemGtk : public DownloadItem::Observer, // The file icon for the download. May be null. SkBitmap* icon_; + // The last download file path for which we requested an icon. FilePath icon_filepath_; |