diff options
| author | ziadh@chromium.org <ziadh@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-07-30 20:39:31 +0000 |
|---|---|---|
| committer | ziadh@chromium.org <ziadh@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-07-30 20:39:31 +0000 |
| commit | 1bc6c551f14f237d5d56b18afb87ea1570483c1c (patch) | |
| tree | 3a5b2c22e19d3d06d82580a88754e944d3aac7c3 /chrome/browser/gtk/external_protocol_dialog_gtk.h | |
| parent | de1e675607fb3f8fb34f90093f3b9500cf3f2e46 (diff) | |
| download | chromium_src-1bc6c551f14f237d5d56b18afb87ea1570483c1c.zip chromium_src-1bc6c551f14f237d5d56b18afb87ea1570483c1c.tar.gz chromium_src-1bc6c551f14f237d5d56b18afb87ea1570483c1c.tar.bz2 | |
Add undeclared virtual destructors part 3
Preventative maintenance for abstract classes that do not declare virtual
destructors. Base classes that do not declare their destructors as virtual
could potentially lead to memory leaks.
These files were discovered using the -Wnon-virtual-dtor flag in g++.
r=jar
BUG=47469
Review URL: http://codereview.chromium.org/3072010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54373 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/gtk/external_protocol_dialog_gtk.h')
| -rw-r--r-- | chrome/browser/gtk/external_protocol_dialog_gtk.h | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/chrome/browser/gtk/external_protocol_dialog_gtk.h b/chrome/browser/gtk/external_protocol_dialog_gtk.h index 6416b30..0703bc8 100644 --- a/chrome/browser/gtk/external_protocol_dialog_gtk.h +++ b/chrome/browser/gtk/external_protocol_dialog_gtk.h @@ -18,6 +18,9 @@ class ExternalProtocolDialogGtk { public: explicit ExternalProtocolDialogGtk(const GURL& url); + protected: + virtual ~ExternalProtocolDialogGtk() {} + private: CHROMEGTK_CALLBACK_1(ExternalProtocolDialogGtk, void, OnDialogResponse, int); |